Merged
Conversation
|
+1 loving this |
Member
|
This looks great! 🎉 I want to take some time to go over this because I think this is an important feature. Hold tight. |
colebemis
approved these changes
Nov 5, 2017
Member
colebemis
left a comment
There was a problem hiding this comment.
Just spent some time reviewing the code. Looks great!
I made some minor changes to the appearance of the search bar. Can you look over my changes and just give me a 👍 if you think it's ready to merge? 🎉
| @@ -0,0 +1,3 @@ | |||
| bell: notification | |||
| bell-off: notification-off | |||
| check: tick | |||
Member
There was a problem hiding this comment.
I think eventually we'll want to keep this data somewhere else but this should be fine for now.
Author
|
Looks good to me 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👋 Love this icon set. Thought I would have a go at adding search with basic tagging system to the home page as I find myself using the bowser page search on the website almost every time I need to use a new icon.
The search works off of listjs as I have seen suggested a few times in some issues. The tags are defined using a simple tags.yml file which is loaded using the Jekyl _data folder. Multiple tags can be defined for an icon by separating them with commas or spaces. You may want to bundle the tags into the feather library itself, however, I think it is fine to keep it as a feature of the website and keep the icons to their specific names.
#44
#45