Reorder package.svg to fix the icon when filled#1275
Open
remi-marchand-zip wants to merge 1 commit intofeathericons:mainfrom
Open
Reorder package.svg to fix the icon when filled#1275remi-marchand-zip wants to merge 1 commit intofeathericons:mainfrom
remi-marchand-zip wants to merge 1 commit intofeathericons:mainfrom
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that when the package icon is 'filled', the top bit of the box is covered up, making it look like the box icon. Example:
By re-ordering the svg elements, the icon remains the same but fill works. Example:
Change:
Test plan
I tested the icon by checking how it looked in its default state (fill="none") before and after. I then tested again with a fill that I added (fill="yellow") to confirm that I fixed it.