Skip to content

chore: Add Milvus to pr_integration_tests.yml #4891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lokeshrangineni merged 2 commits into from
Jan 3, 2025
Merged

chore: Add Milvus to pr_integration_tests.yml #4891

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
984ed5f
Add Milvus to pr_integration_tests.yml
franciscojavierarceo Jan 3, 2025
dcd0a83
upgrading to v2.5.1 and removing milvus service key
franciscojavierarceo Jan 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/pr_integration_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,10 @@ jobs:
run: |
docker pull vishnunair/docker-redis-cluster:latest
docker run -d -p 6001:6379 -p 6002:6380 -p 6003:6381 -p 6004:6382 -p 6005:6383 -p 6006:6384 --name redis-cluster vishnunair/docker-redis-cluster
- name: Setup Milvus Cluster
run: |
wget https://github.com/milvus-io/milvus/releases/download/v2.5.1/milvus-standalone-docker-compose.yml -O docker-compose.yml
docker compose up -d

@lokeshrangineni lokeshrangineni Jan 3, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we need to tear down the cluster before ending the job?

@franciscojavierarceo franciscojavierarceo Jan 3, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, we don't for Redis. It'll happen automatically by the action. You can confirm this in the example I linked here: https://github.com/franciscojavierarceo/testing-github-action-sandbox/actions/runs/12602548011/job/35125851535

@lokeshrangineni lokeshrangineni Jan 3, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure why do we need both one in action and services? do we need at both places? Looks like we are following the same pattern for redis as well.

@franciscojavierarceo franciscojavierarceo Jan 3, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some benefits for services but for Milvus, the service isn't necessary. I just followed what I thought was the convention but it's not necessary. I'll update the PR. 👍

- name: Test python
if: ${{ always() }} # this will guarantee that step won't be canceled and resources won't leak
env:
Expand Down