Fix deprecated use of 0/NULL in squangle/mysql_client/QueryBenchmark.…

…cpp + 3

Summary:
`nullptr` is typesafe. `0` and `NULL` are not. In the future, only `nullptr` will be allowed.

This diff helps us embrace the future _now_ in service of enabling `-Wzero-as-null-pointer-constant`.

Reviewed By: meyering

Differential Revision: D54163075

fbshipit-source-id: 2e303f0581ebdebe9a895bc762e5fcc930946a39

Deshim //folly:dynamic to //folly/json:dynamic in squangle

Summary:
The following headers were shimmed in //folly:dynamic and were modded:
  - folly/DynamicConverter.h -> folly/json/DynamicConverter.h
  - folly/dynamic.h -> folly/json/dynamic.h
  - folly/dynamic-inl.h -> folly/json/dynamic-inl.h
  - folly/json.h -> folly/json/json.h

`arc lint` was applied

Reviewed By: jkedgar

Differential Revision: D53837528

fbshipit-source-id: 8967eee2493f7c7db9e22cac19ce78721b4912a2

Cleanup Operation::setAsyncClientError version which defaults to CR_U…

…NKNOWN_ERROR

Summary: Cleanup Operation::setAsyncClientError version which defaults to CR_UNKNOWN_ERROR, now that all references are removed/

Reviewed By: jkedgar

Differential Revision: D53554192

fbshipit-source-id: 7217213ba48b66bc2e5dcb1cda741bba09379ba0

Deprecate StringKeyedUnorderedMap for squangle

Summary: `folly::StringKeyedUnorderedMap` used to be a complicated class, but is now a simple typedef to `F14NodeMap<std::string, Mapped>`. Just use the latter.

Reviewed By: jkedgar

Differential Revision: D53232226

fbshipit-source-id: d3810649691b2aa7055eb4cee5c0ef8683cf7f3c

Fix potential undefined behavior

Summary:
CLANGTIDY pointed out that this was potentially undefined behavior as we dereferenced `op` and moved `op` (in `deferValue()`)in the same statement and that there was no guarantee which order the two operations were done in.

Change the code to explicitly get the dereference done first.

Reviewed By: fadimounir

Differential Revision: D52819380

fbshipit-source-id: 99fc7620b818b3a766ebc37ffdaa6ecccb85e993

Fix potential undefined behavior

Summary:
CLANGTIDY pointed out that this was potentially undefined behavior as we dereferenced `op` and moved `op` (in `deferValue()`)in the same statement and that there was no guarantee which order the two operations were done in.

Change the code to explicitly get the dereference done first.

Reviewed By: fadimounir

Differential Revision: D52819380

fbshipit-source-id: 99fc7620b818b3a766ebc37ffdaa6ecccb85e993

Remove extra semi colon from squangle/mysql_client/Row.cpp

Summary:
`-Wextra-semi` or `-Wextra-semi-stmt`

If the code compiles, this is safe to land.

Reviewed By: dmm-fb

Differential Revision: D51777911

fbshipit-source-id: bcfd46ade9c05669a1cb9afbb7b9e172200f667d

Remove extra semi colon from squangle/mysql_client/Row.cpp

Summary:
`-Wextra-semi` or `-Wextra-semi-stmt`

If the code compiles, this is safe to land.

Reviewed By: dmm-fb

Differential Revision: D51777911

fbshipit-source-id: bcfd46ade9c05669a1cb9afbb7b9e172200f667d

Remove extra semi colon from squangle/mysql_client/Row.cpp

Summary:
`-Wextra-semi` or `-Wextra-semi-stmt`

If the code compiles, this is safe to land.

Reviewed By: dmm-fb

Differential Revision: D51777911

fbshipit-source-id: bcfd46ade9c05669a1cb9afbb7b9e172200f667d

Remove extra semi colon from squangle/mysql_client/Row.cpp

Summary:
`-Wextra-semi` or `-Wextra-semi-stmt`

If the code compiles, this is safe to land.

Reviewed By: dmm-fb

Differential Revision: D51777911

fbshipit-source-id: bcfd46ade9c05669a1cb9afbb7b9e172200f667d