Skip to content

Conversation

@dpDesignz
Copy link
Contributor

Resolves #200 and also fixed phpunit error expectExceptionMessageRegExp() is deprecated in PHPUnit 8 and will be removed in PHPUnit 9. Use expectExceptionMessageMatches() instead.

Resolves ezSQL#200 and also fixed phpunit error `expectExceptionMessageRegExp() is deprecated in PHPUnit 8 and will be removed in PHPUnit 9. Use expectExceptionMessageMatches() instead.`
@TheTechsTech
Copy link
Contributor

Refresh/sync the changes in .travis.yml and composer.json, i fixed the configuration issues causing build stop errors.

I see your changes causing some fail tests.

Also the phpunit warning messages is not a big issue, fixing them might break other version tests, cause they might not be available in lower phpunit or php versions, and only worth it if phpunit 9 is force by some future version of PHP. The changes can stay as you have if not breaking other versions.

@dpDesignz dpDesignz closed this Feb 6, 2021
@dpDesignz dpDesignz reopened this Feb 6, 2021
@dpDesignz
Copy link
Contributor Author

Refresh/sync the changes in .travis.yml and composer.json, i fixed the configuration issues causing build stop errors.

I see your changes causing some fail tests.

Also the phpunit warning messages is not a big issue, fixing them might break other version tests, cause they might not be available in lower phpunit or php versions, and only worth it if phpunit 9 is force by some future version of PHP. The changes can stay as you have if not breaking other versions.

How do you mean refresh/sync the changes? I'm not sure how to do that? My repo was up to date with the master according to github?

The failed tests seemed to be triggered from old files, because the lines that failed don't exist anymore. Thought it was a bit weird.

The functions that I changed them to have been available since 2013 from what I could see in the docs, so they shouldn't break anything 😄

@TheTechsTech
Copy link
Contributor

I meant pull sync with master branch again, i just found out that my push/update actually cause your PR to run again.

Just check the tests results on travis ci you will see what i mean for failing tests.
Try adding drop tablets before each of those tests, or use totally different table/names instead, they could be from other tests causing issue.

@TheTechsTech TheTechsTech merged commit 66e82e6 into ezSQL:master Feb 8, 2021
TheTechsTech added a commit that referenced this pull request Feb 8, 2021
…red in doing so

- bug fixes, prior to PHP 8, `**@**` silenced errors which this library used to return `**false**` instead, that is not no longer possible with PHP 8
- Linux and Windows CI tests move to GitHub Actions
- General code style fixes
- merged bug fix #199
- fixed tests in issue #200, and corrections for PR #201
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tests for JOIN needs fixing

2 participants