fix: product name hygiene, bundle removal, and wireless io cleanup - #595
Merged
Conversation
…ulary Wireless capabilities are not physical ports. Removed Bluetooth io entries from 31 hardware files and Wi-Fi from the KEF XiO, dropped bluetooth/wifi from schema/io-types.yaml so imports fail validation instead of reintroducing them, and corrected the Midas MR18 Ethernet and ULTRANET ports mislabeled as dante. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…entries Renamed ~310 entries: stripped page-title taglines, trademark symbols, HTML entities, and manufacturer-name prefixes (the manufacturer is stored and indexed separately). Reattributed seven Sonuscore storefront listings to their actual developers (Wavelet Audio, Soundiron) and added searchTerms where names became bare acronyms or lost a commonly searched compound form. Removed 86 standalone bundle/suite entries whose member products exist individually — a bundle is a commercial SKU, not a discrete product. Kept integrated products that only carry Suite/Bundle in the name (Waldorf Edition 2, PSP MixPack2, Red 2 and 3 Plug-in Suite, etc.). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
pnpm validate now hard-fails on mechanical name junk (E118: trademark symbols, HTML entities, stray edge separators, doubled spaces) and warns on manufacturer-name prefixes (W129) and tagline-style en/em-dash or pipe separators (W130, with a reviewed exclusion list). pnpm dataset:audit gains Tier-2 review checks for plain-hyphen name taglines and bundle/suite entries (with an allowlist for integrated products). Conventions documented in CLAUDE.md and docs/VALIDATION_ERRORS.md; the racks /catalog-import commands carry the matching import-time rules. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: e017a88 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Important Review skippedToo many files! This PR contains 348 files, which is 48 over the limit of 300. To get a review, narrow the scope: Usage-priced reviews support at most 300 files. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (435)
You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
6 tasks
Merged
jeffreylouden
added a commit
that referenced
this pull request
Aug 12, 2026
pnpm audit ran as the first step of the validate job, so five high advisories in dev-only transitive deps skipped every data check behind it. The Validate check has been red on every PR since 2026-07-21 regardless of content. Move the audit into its own job so an upstream advisory can never mask data validation again, and trigger on dependency manifests so renovate PRs get a run at all. The advisories were a stale lockfile, not an unpatched range. Every vulnerable package floats to a patched version on a clean resolve, so no new overrides. @changesets/cli 3.0.0 moves to the ESM @manypkg/get-packages 3.x, dropping read-yaml-file and js-yaml from the tree entirely, so both of those overrides retire. Regenerate schema/json/hardware.json, stale since #595 dropped bluetooth/wifi from the io vocabulary. That check never ran while the audit was failing. Refs AUREO-781 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
jeffreylouden
added a commit
that referenced
this pull request
Aug 12, 2026
pnpm audit ran as the first step of the validate job, so five high advisories in dev-only transitive deps skipped every data check behind it. The Validate check has been red on every PR since 2026-07-21 regardless of content. Move the audit into its own job so an upstream advisory can never mask data validation again, and trigger on dependency manifests so renovate PRs get a run at all. The advisories were a stale lockfile, not an unpatched range. Every vulnerable package floats to a patched version on a clean resolve, so no new overrides. @changesets/cli 3.0.0 moves to the ESM @manypkg/get-packages 3.x, dropping read-yaml-file and js-yaml from the tree entirely, so both of those overrides retire. Regenerate schema/json/hardware.json, stale since #595 dropped bluetooth/wifi from the io vocabulary. That check never ran while the audit was failing. Refs AUREO-781 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
jeffreylouden
added a commit
that referenced
this pull request
Aug 12, 2026
pnpm audit ran as the first step of the validate job, so five high advisories in dev-only transitive deps skipped every data check behind it. The Validate check has been red on every PR since 2026-07-21 regardless of content. Move the audit into its own job so an upstream advisory can never mask data validation again, and trigger on dependency manifests so renovate PRs get a run at all. The advisories were a stale lockfile, not an unpatched range. Every vulnerable package floats to a patched version on a clean resolve, so no new overrides. @changesets/cli 3.0.0 moves to the ESM @manypkg/get-packages 3.x, dropping read-yaml-file and js-yaml from the tree entirely, so both of those overrides retire. Regenerate schema/json/hardware.json, stale since #595 dropped bluetooth/wifi from the io vocabulary. That check never ran while the audit was failing. Refs AUREO-781 Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nanobox | tangerine – Compact Streaming Sampler→Nanobox Tangerine), trademark symbols (™/®/©), HTML entities, and manufacturer-name prefixes (dbx 286s→286s— the manufacturer is indexed separately). Reattributed seven Sonuscore storefront listings to their real developers (Wavelet Audio, Soundiron); addedsearchTermswhere names became bare acronyms or lost a searched compound form (EHX by JHS Big Muff 2, BAE 8CR, dbx DDP/DJDI).pnpm validatehard-fails on mechanical name junk (E118) and warns on manufacturer prefixes (W129) and tagline separators (W130);pnpm dataset:auditgainsname-taglineandbundle-entryTier-2 review checks (bundle-entry already surfaces a 68-entry review worklist). Conventions documented in CLAUDE.md and docs/VALIDATION_ERRORS.md; matching import-time rules added to the racks/catalog-importcommands (separate repo).bluetooth/wififrom the io type vocabulary (capabilities, not ports); fixed the Midas MR18's Ethernet/ULTRANET ports mislabeled asdante.Changes
Validation
🤖 Generated with Claude Code