catalog-import: cordoba (93 products) - #583
Merged
Merged
Conversation
Headless import via /catalog-import-headless. Tier: unspecified New entries: 95 Auto-selected images: 270/659 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 91f3c3a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (94)
🚧 Files skipped from review as they are similar to previous changes (86)
WalkthroughThis change adds 93 Córdoba guitar and ukulele hardware records. Each record includes catalog metadata and instrument specifications. Some records also include output-jack I/O data, cosmetic variants, and YouTube references. A Changesets entry declares the catalog update as minor. ChangesUkulele hardware records
Guitar hardware records
Catalog release metadata
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to This change adds Cordoba product records to the catalog, and no actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 18
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@data/hardware/cordoba-15cm-e-edge-burst.yaml`:
- Line 13: Correct the catalog description text in the 15CM-E entry by changing
“available in in soprano” to “available in soprano,” without altering the
surrounding product content.
In `@data/hardware/cordoba-15sm.yaml`:
- Around line 8-14: Update the duplicated family-description prose in the YAML
description and details fields to add the missing comma after “concert
(15CM-E)”, preserving all other catalog content unchanged.
In `@data/hardware/cordoba-15tb-e.yaml`:
- Around line 11-12: Update the product’s structured exclusivity field near the
`details` metadata to match the description: mark the model as exclusive to
Guitar Center in the United States, while preserving the existing prose.
In `@data/hardware/cordoba-20bm.yaml`:
- Around line 8-14: In data/hardware/cordoba-20bm.yaml lines 8-14 and
data/hardware/cordoba-20sm.yaml lines 8-14, update both the description and
details copies of the family description to add a comma after “concert (20CM)”,
preserving the remaining text unchanged.
- Around line 40-49: Normalize the dimension values in the hardware
specification by updating Body Length to use 13 3/4" and adding the missing mm
unit to Upper Bout Width, preserving the existing YAML field names and
formatting.
In `@data/hardware/cordoba-20cm.yaml`:
- Line 48: Correct the specification label typo in the YAML data by renaming
“Upper Bouth Width” to “Upper Bout Width,” preserving the existing value and
formatting.
In `@data/hardware/cordoba-24t-spruce.yaml`:
- Around line 8-9: Correct the typo in the product description by changing
“featuers” to “features” while leaving the rest of the description unchanged.
In `@data/hardware/cordoba-25c.yaml`:
- Around line 10-11: Update the details text for the Córdoba 25C configuration
by correcting the misspelled word “originas” to “origins,” without changing the
surrounding description.
In `@data/hardware/cordoba-25s.yaml`:
- Around line 9-10: Update the product description in the details field for the
25 Series to replace the typo “originas” with “origins,” leaving the rest of the
text unchanged.
In `@data/hardware/cordoba-abasi-stage-7-acacia.yaml`:
- Around line 1-7: Consolidate the three identical Abasi Stage 7 products into
the canonical record in data/hardware/cordoba-abasi-stage-7-acacia.yaml,
preserving shared hardware, capabilities, specifications, and I/O while adding
variants for each finish with its finish-specific name, URL, ID, and SKU. Update
data/hardware/cordoba-abasi-stage-7-white-burst.yaml lines 1-7 and
data/hardware/cordoba-abasi-stage-7-ziricote.yaml lines 1-7 by removing their
duplicated top-level records; those values must be represented only under the
canonical product’s variants.
In `@data/hardware/cordoba-c10-sp.yaml`:
- Around line 11-12: Rewrite the details text for the records at
data/hardware/cordoba-c10-sp.yaml lines 11-12, data/hardware/cordoba-c12-cd.yaml
lines 11-12, and data/hardware/cordoba-c12-sp.yaml lines 11-12 so each
description names only its exact model and top variant, removing alternate
Cedar/Spruce wording while preserving accurate construction details.
In `@data/hardware/cordoba-c4-ce.yaml`:
- Around line 8-10: Update the description value for the C4-CE Edge in the YAML
so it explicitly says “solid mahogany top, mahogany back and sides, and mahogany
neck,” while preserving the remaining tone, cutaway, and Fishman Presys VT
details.
In `@data/hardware/cordoba-c7-cd.yaml`:
- Around line 11-12: Update the details blocks for
data/hardware/cordoba-c7-cd.yaml lines 11-12 and
data/hardware/cordoba-c7-sp.yaml lines 11-12 so each record describes only its
own top-material configuration: Cedar for the C7 CD and Spruce for the C7 SP,
removing language that presents both materials as selectable options.
In `@data/hardware/cordoba-c9-cd.yaml`:
- Around line 11-12: Update the details text for the C9-CD record to describe
only the Canadian Cedar-top model; remove the alternative European Spruce top
reference while preserving the remaining C9 product description.
In `@data/hardware/cordoba-hauser.yaml`:
- Line 10: Correct the grammatical typo in the introductory description by
changing “what is it today” to “what it is today,” and apply this correction
only to the catalog prose.
In `@data/hardware/cordoba-mini-m.yaml`:
- Around line 9-10: Update the structured Neck Shape field in the Mini M
hardware entry from C Shape to the maker-specified U-shaped profile, keeping it
consistent with the existing details text.
In `@data/hardware/cordoba-stage-artist-agave-burst.yaml`:
- Line 65: Correct the shared `Upper Bouth Width` label typo by renaming it to
`Upper Bout Width` in data/hardware/cordoba-stage-artist-agave-burst.yaml at
lines 65-65 and data/hardware/cordoba-stage-artist-traditional.yaml at lines
65-65.
In `@data/hardware/cordoba-torres.yaml`:
- Around line 12-13: In the Córdoba Torres product details, update the incorrect
word “know” to “known” while preserving the surrounding description unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 5e8c85e7-f583-446b-8c39-1fc022634b0b
📒 Files selected for processing (96)
.changeset/import-cordoba.mddata/hardware/cordoba-15c-catalonia-green.yamldata/hardware/cordoba-15cb.yamldata/hardware/cordoba-15cm-e-edge-burst.yamldata/hardware/cordoba-15cm-matiz-mint.yamldata/hardware/cordoba-15cm.yamldata/hardware/cordoba-15sm.yamldata/hardware/cordoba-15tb-e.yamldata/hardware/cordoba-15tm.yamldata/hardware/cordoba-20bm.yamldata/hardware/cordoba-20cm.yamldata/hardware/cordoba-20sm.yamldata/hardware/cordoba-20tm-ce.yamldata/hardware/cordoba-20tm.yamldata/hardware/cordoba-24b-spruce.yamldata/hardware/cordoba-24c-spruce.yamldata/hardware/cordoba-24s-spruce.yamldata/hardware/cordoba-24t-ce-spruce.yamldata/hardware/cordoba-24t-spruce.yamldata/hardware/cordoba-25c.yamldata/hardware/cordoba-25s.yamldata/hardware/cordoba-25t-ce.yamldata/hardware/cordoba-25t.yamldata/hardware/cordoba-35t-ce.yamldata/hardware/cordoba-35t.yamldata/hardware/cordoba-abasi-stage-7-acacia.yamldata/hardware/cordoba-abasi-stage-7-white-burst.yamldata/hardware/cordoba-abasi-stage-7-ziricote.yamldata/hardware/cordoba-c1-matiz-aqua.yamldata/hardware/cordoba-c1.yamldata/hardware/cordoba-c10-cd-lefty.yamldata/hardware/cordoba-c10-cd.yamldata/hardware/cordoba-c10-crossover.yamldata/hardware/cordoba-c10-sp.yamldata/hardware/cordoba-c12-cd.yamldata/hardware/cordoba-c12-sp.yamldata/hardware/cordoba-c1m-1-2.yamldata/hardware/cordoba-c1m-1-4.yamldata/hardware/cordoba-c1m-3-4.yamldata/hardware/cordoba-c1m-ce.yamldata/hardware/cordoba-c1m.yamldata/hardware/cordoba-c3m.yamldata/hardware/cordoba-c4-ce.yamldata/hardware/cordoba-c5-ce-lefty.yamldata/hardware/cordoba-c5-ce-sp.yamldata/hardware/cordoba-c5-ce.yamldata/hardware/cordoba-c5-cet-limited.yamldata/hardware/cordoba-c5-lefty.yamldata/hardware/cordoba-c5-sp.yamldata/hardware/cordoba-c5.yamldata/hardware/cordoba-c7-cd.yamldata/hardware/cordoba-c7-ce-cd.yamldata/hardware/cordoba-c7-sp.yamldata/hardware/cordoba-c9-cd.yamldata/hardware/cordoba-c9-crossover.yamldata/hardware/cordoba-c9-parlor.yamldata/hardware/cordoba-cadete.yamldata/hardware/cordoba-dolce.yamldata/hardware/cordoba-esteso-sp.yamldata/hardware/cordoba-f10.yamldata/hardware/cordoba-f7-flamenco.yamldata/hardware/cordoba-f7-paco.yamldata/hardware/cordoba-friederich.yamldata/hardware/cordoba-fusion-12-cinnamon-burst.yamldata/hardware/cordoba-fusion-12-maple.yamldata/hardware/cordoba-fusion-12-natural-cd.yamldata/hardware/cordoba-fusion-12-rose-ii.yamldata/hardware/cordoba-fusion-12-white-sands.yamldata/hardware/cordoba-fusion-14-maple.yamldata/hardware/cordoba-fusion-5-edge-burst.yamldata/hardware/cordoba-fusion-5-natural.yamldata/hardware/cordoba-gk-pro-negra.yamldata/hardware/cordoba-gk-studio-lefty.yamldata/hardware/cordoba-gk-studio-limited.yamldata/hardware/cordoba-gk-studio-negra-lefty.yamldata/hardware/cordoba-gk-studio-negra.yamldata/hardware/cordoba-gk-studio.yamldata/hardware/cordoba-hauser.yamldata/hardware/cordoba-mini-ii-bass-mh-e.yamldata/hardware/cordoba-mini-ii-eb-ce.yamldata/hardware/cordoba-mini-ii-fmh.yamldata/hardware/cordoba-mini-ii-mh-ce.yamldata/hardware/cordoba-mini-ii-mh.yamldata/hardware/cordoba-mini-m.yamldata/hardware/cordoba-orchestra-ce-cd.yamldata/hardware/cordoba-orchestra-ce-teardrop-burst.yamldata/hardware/cordoba-requinto.yamldata/hardware/cordoba-rodriguez.yamldata/hardware/cordoba-stage-artist-agave-burst.yamldata/hardware/cordoba-stage-artist-traditional.yamldata/hardware/cordoba-stage-black-burst.yamldata/hardware/cordoba-stage-edge-burst.yamldata/hardware/cordoba-stage-natural-amber.yamldata/hardware/cordoba-stage-traditional-cd.yamldata/hardware/cordoba-torres.yamldata/hardware/cordoba-u1b.yaml
Fold the three Abasi Stage 7 finishes into one record with variants, matching the four colorway families already folded in this import. Make the C7/C9/C10/C12 details SKU-specific, correct the 15TB-E exclusivity flag, and fix assorted prose and dimension typos. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Headless catalog import
Counts
Confidence flags
None
Data review
during extraction review; a missed baritone tuning value on U1B fixed
after Agent 1 flagged it; 22 files whose
specsblock was silentlydropped by a generation-script bug — same-shaped string vs. array specs
from one extraction batch — restored)
have thinner
specsblocks than siblings where the manufacturer's ownpage genuinely listed fewer details (not a bug, just thinner source
pages); one entry's specs block starts at
Family:instead ofConstruction:for the same reason. Translations were intentionallynot included in this pass, consistent with existing project practice
(added in a separate later pass across the catalog, not at import time).
Deferred (4 URLs)
Machine-readable list at
scripts/catalog-import/data/cordoba/deferred.json. Run/catalog-import-followup cordobato import these after any blockersare resolved (in this case, none are expected to become standalone
entries, since each bundles an instrument with accessories rather than
adding a new model).
Resume / debug
Per-product extraction state lives at
scripts/catalog-import/data/cordoba/import-state.jsonin the racksrepo until the tier-runner cleans it up.
Auto-merge gate: batched human review (10 PRs at a time).
Summary by CodeRabbit