Skip to content

fix: adjust sleep duration tolerance in tests #1844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tzdybal merged 1 commit into from
Sep 13, 2024
Merged

fix: adjust sleep duration tolerance in tests #1844

tzdybal merged 1 commit into from
Sep 13, 2024

Conversation

@tzdybal
Copy link
Member

@tzdybal tzdybal commented Sep 13, 2024 •
edited by coderabbitai bot
Loading

Increase the sleep duration tolerance in the manager tests from 1 millisecond to 5 milliseconds. This change ensures that the tests are less sensitive to minor timing variations, potentially reducing flaky test failures.

Summary by CodeRabbit

  • Bug Fixes
    • Increased the tolerance for sleep duration assertions to improve accuracy in timing tests.

@tzdybal tzdybal self-assigned this Sep 13, 2024
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 13, 2024 •
edited
Loading

Walkthrough

The pull request modifies the test function TestManager_getRemainingSleep by increasing the tolerance for the time difference allowed when asserting the expected sleep duration against the actual duration calculated by the getRemainingSleep method. The tolerance has been adjusted from 1 millisecond to 5 milliseconds, indicating a need for greater flexibility in timing assertions.

Changes

File Change Summary
block/manager_test.go Adjusted the tolerance in the TestManager_getRemainingSleep function from 1 ms to 5 ms.

Possibly related PRs

  • feat: implement getRemainingSleep(start) #1779: This PR modifies the tolerance in the TestManager_getRemainingSleep function, which relates to changes in the getRemainingSleep method regarding sleep duration handling in the Manager class.

Poem

In the burrow where the bunnies sleep,
Tolerance grows, no need to leap.
From one to five, we softly sway,
In dreams of time, we hop and play!
Adjustments made, so all is right,
Sleep well, dear friends, 'til morning light! 🐇✨

Tip

OpenAI O1 model for chat
  • We have deployed OpenAI's latest O1 model for chat.
  • OpenAI claims that this model has superior reasoning capabilities than their GPT-4o model.
  • Please share any feedback with us in the discussions post.
Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 77015a5 and a3d2434.

Files selected for processing (1)
  • block/manager_test.go (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • block/manager_test.go

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@RollkitBot RollkitBot requested review from a team, MSevey, tuxcanfly and yarikbratashchuk and removed request for a team September 13, 2024 12:16
@tzdybal tzdybal enabled auto-merge September 13, 2024 12:17
@codecov
Copy link

codecov bot commented Sep 13, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.12%. Comparing base (ca2edbf) to head (a3d2434).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1844      +/-   ##
==========================================
- Coverage   43.17%   43.12%   -0.06%     
==========================================
  Files          80       80              
  Lines       10387    10387              
==========================================
- Hits         4485     4479       -6     
- Misses       5163     5167       +4     
- Partials      739      741       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gupadhyaya gupadhyaya self-requested a review September 13, 2024 12:32
@tzdybal
fix: adjust sleep duration tolerance in tests
a3d2434 
Increase the sleep duration tolerance in the manager tests from 1 millisecond to 5 milliseconds. This change ensures that the tests are less sensitive to minor timing variations, potentially reducing flaky test failures.
@tzdybal tzdybal force-pushed the tzdybal/within_duration branch from 77015a5 to a3d2434 Compare September 13, 2024 12:32
@tzdybal tzdybal added this pull request to the merge queue Sep 13, 2024
Merged via the queue into main with commit 02ebb19 Sep 13, 2024
@tzdybal tzdybal deleted the tzdybal/within_duration branch September 13, 2024 12:40
@tac0turtle tac0turtle removed this from Evolve Apr 24, 2025
@coderabbitai coderabbitai bot mentioned this pull request Apr 26, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gupadhyaya gupadhyaya gupadhyaya approved these changes

@Manav-Aggarwal Manav-Aggarwal Manav-Aggarwal approved these changes

@tuxcanfly tuxcanfly Awaiting requested review from tuxcanfly tuxcanfly was automatically assigned from evstack/core

@yarikbratashchuk yarikbratashchuk Awaiting requested review from yarikbratashchuk yarikbratashchuk was automatically assigned from evstack/core

@MSevey MSevey Awaiting requested review from MSevey MSevey was automatically assigned from evstack/core

Assignees

@tzdybal tzdybal

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tzdybal @gupadhyaya @Manav-Aggarwal