Skip to content

fix: remove category property from RulesMetaDocs interface#345

Merged
fasttime merged 1 commit into
mainfrom
fix/remove-meta-docs-category
Dec 29, 2025
Merged

fix: remove category property from RulesMetaDocs interface#345
fasttime merged 1 commit into
mainfrom
fix/remove-meta-docs-category

Conversation

@Pixel998

Copy link
Copy Markdown
Contributor

Prerequisites checklist

What is the purpose of this pull request?

This PR removes the deprecated category property from the RulesMetaDocs interface. The property was removed from ESLint core in v8.0.0.

What changes did you make? (Give an overview)

Removed the category property from the RulesMetaDocs interface

Related Issues

Is there anything you'd like reviewers to focus on?

@eslint-github-bot eslint-github-bot Bot added the bug Something isn't working label Dec 28, 2025
@github-project-automation github-project-automation Bot moved this to Needs Triage in Triage Dec 28, 2025
@DMartens DMartens moved this from Needs Triage to Triaging in Triage Dec 29, 2025
@DMartens

Copy link
Copy Markdown

Changes LGTM, thanks. Leaving this open for another reviewer who may know why the meta.docs.category type was included in #110 or if it was just an oversight.

@fasttime fasttime moved this from Triaging to Implementing in Triage Dec 29, 2025
@fasttime

Copy link
Copy Markdown
Member

It looks like category is a leftover from @types/eslint (relevant lines: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/7bbd183e29bffb937b00cc115af691c9da0a3b1a/types/eslint/index.d.ts#L703-L704). Typescript‑eslint has already removed it as well.

@fasttime fasttime left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@fasttime
fasttime merged commit b197f00 into main Dec 29, 2025
32 checks passed
@fasttime
fasttime deleted the fix/remove-meta-docs-category branch December 29, 2025 13:13
@github-project-automation github-project-automation Bot moved this from Implementing to Complete in Triage Dec 29, 2025
@github-actions github-actions Bot mentioned this pull request Dec 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accepted bug Something isn't working

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

3 participants