Make sure matching multiline decorators with dots in the content don'…#38
Closed
trbm1 wants to merge 1 commit intoesdoc:masterfrom
trbm1:master
Closed
Make sure matching multiline decorators with dots in the content don'…#38trbm1 wants to merge 1 commit intoesdoc:masterfrom trbm1:master
trbm1 wants to merge 1 commit intoesdoc:masterfrom
trbm1:master
Conversation
…t break the matching.
Author
|
solving: #36 |
Member
|
I can not have reproduce after I merged esdoc/esdoc#472 Can you close this PR? |
Author
|
Thank you for merging my changes @h13i32maru You can see that the second decorator fails. This PR is intended to solve those complex argument. Do you need more information to replay this? LMK. Summary: |
Author
|
Additional note: The DocBuilder.js @ line 701 (splitting operation) will fail when complex decorators are involved. No clue why, because no time to dig in. My fix for now: |
Member
|
This changing breaks the behavior. 'Foo#bar'.match(/(.*)[.#](.*)$/)
// => ["Foo#bar", "Foo", "bar", index: 0, input: "Foo#bar"]
'Foo#bar'.match(/(.*)[.#](?=.*\()(.*)$/)
// => null |
h13i32maru
added a commit
that referenced
this pull request
Apr 30, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…t break the matching.