Skip to content

I suggest adding asynchronous functions to the README usage.#442

Open
2525nicole wants to merge 2 commits into
enquirer:masterfrom
2525nicole:update_README
Open

I suggest adding asynchronous functions to the README usage.#442
2525nicole wants to merge 2 commits into
enquirer:masterfrom
2525nicole:update_README

Conversation

@2525nicole

@2525nicole 2525nicole commented Sep 30, 2023

Copy link
Copy Markdown

Thank you for providing a great library!
If I run the code as written in the README usage, I get an error.
I propose the following modifications to solve this problem and make it easier for beginners like me to use.

There is a note nearby about asynchronous functions, but it would be more helpful if the sample code could be executed as is :)

・CommonJS does not support top-level await, so introduce asynchronous functions.
・For Multiple prompts, added code to import modules.

@2525nicole 2525nicole changed the title I suggest adding asynchronous functions to the README usage I suggest adding asynchronous functions to the README usage. Sep 30, 2023
@jonschlinkert

Copy link
Copy Markdown
Member

This is great, thank you @2525nicole!

If it's not too much trouble, would you mind updating all quotes to single quotes, and revert formatting of markdown tables, so we can minimize the differences and see the actual changes that were made? I will still merge this in if you don't have time.

Thanks again!

@2525nicole

2525nicole commented Oct 1, 2023

Copy link
Copy Markdown
Author

Hello, @jonschlinkert :)

First and foremost, I would like to sincerely thank you for taking time out of your busy schedule to send me a positive message and promptly review my pull request.

I would also like to apologize for inadvertently making unnecessary changes in your previous pull request. I will now modify the code and submit it to you!
I would appreciate it if you could give us a little more time. Thank you very much.

@2525nicole

Copy link
Copy Markdown
Author

Thank you for your patience, @jonschlinkert !
I have completed the correction of the code and would appreciate it if you could check it again.
I sincerely apologize for any inconvenience caused.
Best regards.

@2525nicole

Copy link
Copy Markdown
Author

@jonschlinkert
How about this one? If you see no problem, we would appreciate it if you could merge it in🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants