This repository was archived by the owner on Aug 19, 2025. It is now read-only.
Merged
Conversation
|
LGTM! |
Contributor
|
I'll release tonight |
ghost
reviewed
Mar 1, 2024
| [aiohttp]: https://github.com/aio-libs/aiohttp | ||
| [tornado]: https://github.com/tornadoweb/tornado | ||
| [fastapi]: https://github.com/tiangolo/fastapi No newline at end of file | ||
| [fastapi]: https://github.com/tiangolo/fastapi |
There was a problem hiding this comment.
What happened here? Was a newline inserted or removed?
Contributor
There was a problem hiding this comment.
This just looks like a trailing newline which seems fine
ghost
reviewed
Mar 1, 2024
| [aiohttp]: https://github.com/aio-libs/aiohttp | ||
| [tornado]: https://github.com/tornadoweb/tornado | ||
| [fastapi]: https://github.com/tiangolo/fastapi No newline at end of file | ||
| [fastapi]: https://github.com/tiangolo/fastapi |
Contributor
Author
|
@ansipunk of you are happy. We can merge it for @Kludex to be able to release it tonight. |
zanieb
approved these changes
Mar 1, 2024
Contributor
|
Thanks for working on this! I've published the release. |
Contributor
|
Thanks @zanieb ❤️👍 |
Contributor
Author
|
Thank you @zanieb 🙂. It's a pleasure to be able to help. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@encode/maintainers let me know if this is enough.