-
Notifications
You must be signed in to change notification settings - Fork 68
Write to manifest #439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Write to manifest #439
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
c2fd900
Write to manifest
bryanjos 3ae89c6
Move manifest writing to top level of compiler
bryanjos a9f1581
Fix lints
bryanjos a0e5eb1
Add output path for js_path
bryanjos cda84c3
Update lint settings
bryanjos 3c8dcd1
Move manifest writing to the mix compiler
bryanjos cf0b415
Fix lint
bryanjos 016c774
Add manifest test
bryanjos File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -24,3 +24,4 @@ cover | |
| /priv/build | ||
| /tmp | ||
| .esm-cache | ||
| .elixir_ls | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| defmodule ElixirScript.Manifest do | ||
| @moduledoc false | ||
|
|
||
| @spec read_manifest(binary) :: nil | ||
| def read_manifest(_manifest) do | ||
|
|
||
| end | ||
|
|
||
| @spec write_manifest(binary, map) :: :ok | ||
| def write_manifest(manifest_path, modules) do | ||
| data = Enum.reduce(modules, %{}, fn {module, info}, current_data -> | ||
| Map.put(current_data, module, Map.drop(info, [:js_code])) | ||
| end) | ||
|
|
||
| data = :erlang.term_to_binary(data, [:compressed]) | ||
| File.mkdir_p!(Path.dirname(manifest_path)) | ||
| File.write!(manifest_path, data) | ||
|
|
||
| :ok | ||
| end | ||
| end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| defmodule ElixirScript.Manifest.Test do | ||
| use ExUnit.Case | ||
| alias ElixirScript.Manifest | ||
|
|
||
| test "write manifest" do | ||
| result = ElixirScript.Compiler.compile(Atom) | ||
| path = Path.join([System.tmp_dir(), "write_manifest_test", ".compile.elixir_script"]) | ||
| Manifest.write_manifest(path, result) | ||
| assert File.exists?(path) | ||
| end | ||
|
|
||
| end |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line is too long (max is 80, was 94).