Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: sabbasbraimah/java-technical-assignment
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: elakkss/java-technical-assignment
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 6 commits
  • 15 files changed
  • 2 contributors

Commits on Nov 12, 2019

  1. Revisions to limit scope of test to discount pricing (#1) 

    * Added JUnit 5 to project
* Revised README
* Added Basket/Item
* Item price determined by the Product it references
Products are discriminated by measurement (item vs weight)
Item instances are created from Product/WeighedProduct
* Updated README to reference the provided code
Tweaked Basket to illustrate where candidate could add discounting functionality
* Renamed Basket -> Basket to indicate the intended limits of its responsibility.
Added TODO comment on Basket.discounts() to highlight where this could interact with something to provide that functionality.
    David Wood authored Nov 12, 2019
    Configuration menu
    Copy the full SHA
    ea3ef51 View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2020

  1. Reworked README to be more explicit about discount modelling requirem… 

    …ent (#2)

Tidied up lines to character limits
    David Wood authored Jan 27, 2020
    Configuration menu
    Copy the full SHA
    87664fa View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2020

  1. Adding Offer related code 

    New Offer interface, BuyXGetYFree class for Buy 1 Get 1 free offer, adding
    @elakkss
    elakkss committed Feb 6, 2020
    Configuration menu
    Copy the full SHA
    97db91d View commit details
    Browse the repository at this point in the history

  2. Code to apply discount added 

    Added main code to apply discount in all items in the basket.  added tests for basket with offer.
    @elakkss
    elakkss committed Feb 6, 2020
    Configuration menu
    Copy the full SHA
    b7cbf67 View commit details
    Browse the repository at this point in the history

  3. Offer constructor 

    adding offer constructor
    @elakkss
    elakkss committed Feb 6, 2020
    Configuration menu
    Copy the full SHA
    92fb428 View commit details
    Browse the repository at this point in the history

  4. Adding comments to all the code and removing log lines 

    Adding comments to all the code and removing log lines
    @elakkss
    elakkss committed Feb 6, 2020
    Configuration menu
    Copy the full SHA
    19c3854 View commit details
    Browse the repository at this point in the history
Loading