extending shutdown to handle single agent setup in relayed mode#19
Merged
armin-acn merged 3 commits intoeclipse-score:mainfrom Nov 24, 2025
Merged
Conversation
License Check Results🚀 The license check job ran with the Bazel command: bazel run //:license-checkStatus: Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
Signed-off-by: ShoroukRamzy <82869891+ShoroukRamzy@users.noreply.github.com>
| // (100.into(), vec![w40, w41, w42, w43, w44]), | ||
| // ] | ||
| // .into_iter() | ||
| // .collect(); |
| recorder_ids: vec![], | ||
| worker_assignments: agent_assignments().remove(&AGENT_ID).unwrap(), | ||
| timeout: Duration::from_secs(10), | ||
| timeout: Duration::from_secs(60), |
Contributor
There was a problem hiding this comment.
Why do we need a longer timeout?
Contributor
Author
There was a problem hiding this comment.
while testing the single agent in relayed mode I encountered sporadic issue of missing all worker connections within the timeout, that's why I needed to increase the timeout.
Contributor
There was a problem hiding this comment.
If there is a separate issue, we better make a separate ticket for it. I don't think it's a good idea to mask the issue with an unreasonably long timeout, especially as part of an unrelated PR.
Contributor
Author
There was a problem hiding this comment.
Thanks @artemsheinacn, I fully agree with you. I will revert it
Contributor
|
@armin-acn please review when you have time |
4c11f36 to
8220056
Compare
artemsheinacn
approved these changes
Nov 19, 2025
Contributor
artemsheinacn
left a comment
There was a problem hiding this comment.
Thanks for the PR @ShoroukRamzy!
Contributor
Author
Thank you for your feedbacks @artemsheinacn |
Contributor
Author
Hi @armin-acn, I don't have permissions to merge this PR. Could you please help me with this when you have time? Thanks! |
armin-acn
approved these changes
Nov 24, 2025
dcleoliu
pushed a commit
to dcleoliu/feo
that referenced
this pull request
Mar 1, 2026
…pse-score#19) * extending shutdown to handle single agent setup in relayed mode * extending shutdown to handle single agent setup in relayed mode --------- Signed-off-by: ShoroukRamzy <82869891+ShoroukRamzy@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @artemsheinacn,
This PR fixes a deadlock during shutdown when using a relayed signaling mode in a single-agent setup as per our discussion here
#17
The PrimaryReceiveRelay thread would block indefinitely waiting for remote agents that don't exist. The fix is to prevent the relay threads from being created at all in this scenario, as all workers are local and communicate via MPSC.
The SchedulerConnector for the relayed mode now conditionally creates the PrimaryReceiveRelay and PrimarySendRelay only if there are remote agents configured. This makes the shutdown clean and avoids spawning an unnecessary thread.
Thanks!