Skip to content

Remove SDLValidationParameters from pipeline files - #3011

Merged
MihaZupan merged 1 commit into
mainfrom
copilot/fix-unexpected-sdlvalidationparameters-error
Apr 10, 2026
Merged

MihaZupan merged 1 commit into
mainfrom
copilot/fix-unexpected-sdlvalidationparameters-error

Conversation

Copilot AI commented Apr 8, 2026

Copy link
Copy Markdown
Contributor

Arcade SDK 11.0.0-beta.26204.1 (ingested via #3001) removed SDLValidationParameters from eng/common/core-templates/post-build/post-build.yml. The wrapper template forwards all parameters via ${{ each parameter in parameters }}, so passing the now-undeclared parameter causes Azure DevOps YAML expansion to fail:

/eng/common/templates-official/post-build/post-build.yml (Line: 7, Col: 5): Unexpected parameter 'SDLValidationParameters'

SDL scanning is unaffected — it moved to the 1ES Pipeline Template Guardian infrastructure as part of the 1ESPT migration (dotnet/arcade#14531, dotnet/arcade#15140). The per-repo SDLValidationParameters block (PoliCheck, CredScan, TSA config) is no longer consumed by any template.

Other repos that ingested the same Arcade update applied the identical fix:

Changes

  • Removed SDLValidationParameters block from azure-pipelines.yml
  • Removed SDLValidationParameters block from azure-pipelines-nonprod.yml

…elines-nonprod.yml

The SDLValidationParameters parameter was removed from the core post-build
template in eng/common, causing CI to fail with "Unexpected parameter
'SDLValidationParameters'". Remove the now-invalid parameter blocks from
both pipeline files.

Agent-Logs-Url: https://github.com/dotnet/yarp/sessions/6ba32e16-7fcb-44dd-b3b8-aa3ecc9956fe

Co-authored-by: MihaZupan <25307628+MihaZupan@users.noreply.github.com>
@MihaZupan MihaZupan added this to the YARP 3.0 milestone Apr 8, 2026
@MihaZupan MihaZupan added the Type: Infrastructure Infrastructure work that does not affect the actual shipping code label Apr 8, 2026
@MihaZupan
MihaZupan marked this pull request as ready for review April 8, 2026 16:47

@rokonec rokonec left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MihaZupan
MihaZupan merged commit 921585f into main Apr 10, 2026
8 checks passed
@MihaZupan
MihaZupan deleted the copilot/fix-unexpected-sdlvalidationparameters-error branch April 10, 2026 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Infrastructure Infrastructure work that does not affect the actual shipping code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants