perf(streaming): avoid copying memory stream payloads - #10550
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR optimizes the in-memory stream provider’s message-body deserialization path by avoiding an unnecessary ArraySegment<byte>.ToArray() allocation/copy, and instead deserializing directly from the existing ArraySegment<byte> using Orleans’ serializer overload.
Changes:
- Replaced
serializer.Deserialize(bodyBytes.ToArray())withserializer.Deserialize(bodyBytes)to avoid per-payload cloning during batch reads.
Show a summary per file
| File | Description |
|---|---|
| src/Orleans.Streaming/MemoryStreams/MemoryMessageBody.cs | Switch deserialization to use ArraySegment<byte> directly, eliminating an allocation and O(n) copy per payload. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
This was referenced Aug 28, 2026
Merged
This was referenced Sep 4, 2026
This was referenced Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default memory-stream deserializer materializes every serialized payload with
ArraySegment<byte>.ToArray()before deserializing it. This adds an allocation and an O(payload-size) copy for every batch read.Pass the existing
ArraySegment<byte>directly to Orleans' serializer instead. Its segment overload deserializes from the underlying span, preserving offsets and lengths while avoiding the payload clone.