fix(transactions): improve recovery liveness and diagnostics - #10374
Merged
ReubenBond merged 4 commits intoAug 10, 2026
Merged
ReubenBond merged 4 commits into
ReubenBond merged 4 commits into
Conversation
ReubenBond
force-pushed
the
reubenbond-transaction-recovery-upstream-pr
branch
5 times, most recently
from
August 10, 2026 00:05
f5cc913 to
ad02350
Compare
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 926dfb31-52fb-4a8a-8af8-6a9fe3d0e152
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Honor absolute watchdog deadlines even when a timer wakes early, and allow targeted recovery attempts to complete transparently after the owning silo is terminated. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: a9491034-9b04-4ca3-b96b-949371ffea34
ReubenBond
force-pushed
the
reubenbond-transaction-recovery-upstream-pr
branch
from
August 10, 2026 00:44
ad02350 to
693e7a4
Compare
This was referenced Aug 28, 2026
Merged
This was referenced Aug 31, 2026
This was referenced Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #10378 and should be rebased/merged after it. The expected rebase resolution in
TransactionQueue.AbortAndRestoreCorepreserves #10378's discarded-batch completion around #10374's correlated restore/diagnostics;TransactionQueueStorageWorkTestsalso needs the new diagnostic identity constructor argument. This combined resolution has been validated on net8.0 and net10.0.Transaction recovery can linger after orphaned managers, while the existing diagnostics do not expose enough activation, role, phase, lock, restore, and cancellation state to explain liveness failures.
This change adds provider-neutral transaction recovery diagnostics, adaptive recovery-ping retries, and bounded failure detection with explicit outcomes. Local transaction-manager aborts dispatch every target in exactly one manager-owned cancel fan-out before publishing the durable abort decision, preventing TransactionAgent duplication and avoiding the caller response deadline depending on remote cleanup. The already-dispatched cleanup remains observed and is bounded locally by activation cancellation and the configured lock-timeout budget while retaining the original abort status.
Storage-write diagnostics carry the exact committed transaction IDs, so durable local-commit cleanup gates can only be released by confirmation of the gated transaction rather than an unrelated recovery probe. Deterministic phase gates cover manager wait, persisted remote prepare, durable local commit before matching confirmation/collection, and activation cancellation during blocked cancel fan-out. Azure Storage and DynamoDB suites include the provider-backed recovery cases.
Microsoft Reviewers: Open in CodeFlow