Skip to content

refactor: enable nullable reference types across Orleans - #10291

Merged
ReubenBond merged 119 commits into
dotnet:mainfrom
ReubenBond:reubenbond-migrate-nullable-references
Jul 31, 2026
Merged

refactor: enable nullable reference types across Orleans#10291
ReubenBond merged 119 commits into
dotnet:mainfrom
ReubenBond:reubenbond-migrate-nullable-references

Conversation

@ReubenBond

@ReubenBond ReubenBond commented Jul 21, 2026 •
edited by dotnet-policy-service Bot
Loading

Copy link
Copy Markdown
Member

This completes Orleans' nullable reference type migration across source, tests, samples, and playgrounds. It removes nullable opt-outs, annotates public and internal contracts, refreshes generated API surfaces, and enables a repository-wide nullable warning gate. The migration preserves existing runtime behavior while exposing accurate nullability metadata to consumers.\n\nThe full solution builds with zero warnings and errors, and the net10 BVT suite passes with 5,946 passed, 61 skipped, and no failures.

Microsoft Reviewers: Open in CodeFlow

@azure-pipelines

azure-pipelines Bot commented Jul 21, 2026

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

@ReubenBond ReubenBond changed the title Enable nullable reference types across Orleans refactor: enable nullable reference types across Orleans Jul 21, 2026
@ReubenBond
ReubenBond force-pushed the reubenbond-migrate-nullable-references branch 2 times, most recently from fcc8d94 to 22355b3 Compare July 21, 2026 05:32
@ReubenBond
ReubenBond requested a review from Copilot July 21, 2026 17:01
Copilot AI reviewed Jul 21, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

Copilot AI review requested due to automatic review settings July 22, 2026 14:54
@ReubenBond
ReubenBond force-pushed the reubenbond-migrate-nullable-references branch from 22355b3 to 317c396 Compare July 22, 2026 14:54
Copilot AI reviewed Jul 22, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

Copilot AI review requested due to automatic review settings July 31, 2026 17:18
Copilot AI reviewed Jul 31, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

@ReubenBond
ReubenBond force-pushed the reubenbond-migrate-nullable-references branch from 0e5b95e to 12690a9 Compare July 31, 2026 19:24
Copilot AI review requested due to automatic review settings July 31, 2026 19:24
Copilot AI reviewed Jul 31, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

Copilot AI review requested due to automatic review settings July 31, 2026 20:30
Copilot AI reviewed Jul 31, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

ReubenBond and others added 14 commits July 31, 2026 13:32
@ReubenBond
test: enable nullable in remaining test projects
77b65c9 
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 8b3602c8-0a8a-4e43-a73a-b3217fd85778
@ReubenBond
test: migrate analyzer tests to nullable
adf8391 
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: f95a752a-2648-488c-a0b0-821b1df20b36
@ReubenBond
refactor: enable nullable in Orleans.Reminders
9b1640a 
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: cefb03e8-5d03-4f0d-a290-7958fbce53f5
@ReubenBond
test: enable nullable in streaming and transaction tests
55d9708 
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 29c0a149-976b-47ad-9f30-dfb1db9d1c0c
@ReubenBond
test: enable nullable in event sourcing tests
07e50f5 
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 29c0a149-976b-47ad-9f30-dfb1db9d1c0c
@ReubenBond
test: enable nullable in runtime feature tests
cdb08ad 
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 29c0a149-976b-47ad-9f30-dfb1db9d1c0c
@ReubenBond
refactor(serialization): annotate abstraction contracts
e02652a 
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 6f2e889d-345f-4cfa-b20d-21fe21a86843
@ReubenBond
refactor: enable nullable in Orleans.Connections.Security
0a4acbf 
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: cefb03e8-5d03-4f0d-a290-7958fbce53f5
@ReubenBond
refactor: enable nullable in Orleans.Persistence.Memory
7402c2b 
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: cefb03e8-5d03-4f0d-a290-7958fbce53f5
@ReubenBond
refactor: enable nullable in Orleans.BroadcastChannel
804fceb 
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: cefb03e8-5d03-4f0d-a290-7958fbce53f5
@ReubenBond
refactor: enable nullable in Orleans.Core subsystems
7b555e5 
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: cefb03e8-5d03-4f0d-a290-7958fbce53f5
@ReubenBond
refactor: migrate Orleans.Core infrastructure to nullable
12356bd 
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: cefb03e8-5d03-4f0d-a290-7958fbce53f5
@ReubenBond
refactor(runtime): annotate foundational nullable contracts
fdbf519 
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: aadec37a-eac3-42f2-a063-08638f1a3ab9
@ReubenBond
refactor(runtime): annotate cluster directory contracts
f9f5de0 
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: aadec37a-eac3-42f2-a063-08638f1a3ab9
@ReubenBond
fix: preserve legacy provider null handling
111a2b5 
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 6e15bd15-3078-4a67-979c-131c7f1c97ed
@ReubenBond
fix: annotate newly rebased changes
dec1147 
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 6e15bd15-3078-4a67-979c-131c7f1c97ed
@ReubenBond
fix(eventsourcing): preserve state envelope serialization
347333b 
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 6e15bd15-3078-4a67-979c-131c7f1c97ed
@ReubenBond
fix(samples): align nullable API usage
9160579 
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 6e15bd15-3078-4a67-979c-131c7f1c97ed
@ReubenBond
fix(serialization): annotate JSON binder fallback
4138acb 
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 6e15bd15-3078-4a67-979c-131c7f1c97ed
Copilot AI review requested due to automatic review settings July 31, 2026 20:39
@ReubenBond
ReubenBond force-pushed the reubenbond-migrate-nullable-references branch from 43ae90e to 4138acb Compare July 31, 2026 20:39
Copilot AI reviewed Jul 31, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

@ReubenBond
ReubenBond merged commit 10a42f2 into dotnet:main Jul 31, 2026
121 of 124 checks passed
@ReubenBond
ReubenBond deleted the reubenbond-migrate-nullable-references branch July 31, 2026 21:11
@ReubenBond ReubenBond mentioned this pull request Aug 10, 2026
Closed
This was referenced Aug 28, 2026
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Closed
Closed
Closed
Open
Closed
Open
Open
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 31, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ReubenBond