Suggestion to parse solution when projects have similar names - #5367
Merged
Forgind merged 16 commits intoAug 14, 2020
Merged
Conversation
Nirmal4G
reviewed
May 22, 2020
Nirmal4G
left a comment
Contributor
There was a problem hiding this comment.
Naming suggestions. What do you think?
Contributor
|
What's wrong with this: |
Contributor
Author
As far as I know, the unique name is based on the project name, not the file name. |
Co-authored-by: Nirmal Guru <Nirmal4G@gmail.com>
Co-authored-by: Nirmal Guru <Nirmal4G@gmail.com>
rainersigwald
left a comment
Member
There was a problem hiding this comment.
Thanks @joseotavioq! This is looking pretty good. Would you like to mark it ready for review?
Co-authored-by: Rainer Sigwald <raines@microsoft.com>
…m/joseotavioq/msbuild into fix_sln_parser_proj_similar_names
joseotavioq
marked this pull request as ready for review
July 24, 2020 20:33
Forgind
approved these changes
Aug 12, 2020
Forgind
left a comment
Contributor
There was a problem hiding this comment.
I think this works—just one part I wasn't sure of.
Changing comments Co-authored-by: Forgind <Forgind@users.noreply.github.com>
Co-authored-by: Forgind <Forgind@users.noreply.github.com>
Contributor
|
Thanks for your work here! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created a fix to detect collision caused by a unique project name's normalization, reported on issue #3019