Avoid boxing allocations for creation of error message in non-error cases - #12537
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes performance by avoiding unnecessary boxing allocations when creating error messages in non-error scenarios. The change refactors a single line to conditionally format error messages only when the error condition is actually met, eliminating ~11MB of allocations from boxing the message parameters.
Key Changes
- Replaced
ErrorUtilities.VerifyThrowwith manual condition checking followed byErrorUtilities.ThrowInternalError - Added guard condition to only format error message parameters when an error actually occurs
rainersigwald
approved these changes
Sep 22, 2025
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
SimaTian
approved these changes
Sep 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #
Context
With the current way the code is constructed, the parameters for the error message in
ReportResult()end up getting boxed even if they never end up getting used. By expanding this a little and guarding the call based on the error condition, we only pay the allocation cost in the error state.There are ~11MB of allocations due to the types being boxed.
Changes Made
Testing
Notes