Prevent reading from .rsp file for worker nodes - #11170
Merged
YuliiaKovalova merged 3 commits intoJan 2, 2025
Merged
YuliiaKovalova merged 3 commits into
YuliiaKovalova merged 3 commits into
Conversation
JanKrivanek
approved these changes
Dec 18, 2024
Contributor
|
Rather than hard code the argument parsing logic to ignore one thing if another is specified, perhaps it would better to just specify the |
Member
Author
Thank you for the nice tip! I haven't known about this switch before. |
JanProvaznik
approved these changes
Jan 2, 2025
This was referenced Jul 28, 2025
This was referenced Aug 4, 2025
This was referenced Aug 15, 2025
This was referenced Aug 7, 2026
Closed
This was referenced Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Sometimes Windows Defender blocks on
MSBuild.rspfile reading operation (e.g. https://dev.azure.com/devdiv/DevDiv/_workitems/edit/2308633).Since response file content isn't needed for worker nodes, we can skip reading from t.
Changes Made
Add a check for
nodemode:arg in command likeTesting
Local testing when rsp file is manually locked.