[net11] Update test resource URL and resave test image#36100
Merged
Conversation
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 36100Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 36100" |
Contributor
|
Hey there @@SubhikshaSf4851! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
SubhikshaSf4851
temporarily deployed
to
gh-aw-agents
June 24, 2026 12:45 — with 
GitHub Actions
Inactive
SubhikshaSf4851
temporarily deployed
to
gh-aw-agents
June 24, 2026 12:46 — with
GitHub Actions
Inactive
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
…gistration
Two changes to resolve the IL2009 warning that fails AOT integration tests:
1. Rename [Register("__UIGestureRecognizer")] to a unique name to avoid
duplicate ObjC class registration with the SDK's internal type.
2. Remove redundant [Preserve(Conditional = true)] on Activated(). The
[Export("target:")] attribute already makes it a static-registrar root
under full trimming. The [Preserve] generated a preserve descriptor in
apply-preserve-attribute.xml that the linker couldn't resolve against
UIKit.UIGestureRecognizer.Callback<T>, causing IL2009.
Fixes: dotnet#36081
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
vishnumenon2684
force-pushed
the
Fix-35899
branch
from
June 25, 2026 08:25
ce79737 to
876ce18
Compare
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
SubhikshaSf4851
force-pushed
the
Fix-35899
branch
from
June 26, 2026 10:23
f9b98c4 to
2b2df4f
Compare
vishnumenon2684
marked this pull request as ready for review
June 26, 2026 10:33
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates MAUI Controls WebView-related test pages and UI tests to avoid using real-world external domains by switching navigation URLs and cookie-domain expectations to example.com (and related example.* domains), and refreshes a Mac snapshot baseline used by Issue16918Test to address a CI baseline mismatch.
Changes:
- Replace WebView URL sources in HostApp test pages from
microsoft.com/github.com/dotnet.microsoft.comtoexample.comvariants. - Update WebView cookie-management UI test assertions to expect
example.comas the displayed cookie domain. - Refresh the Mac visual snapshot baseline image for
Issue16918Test.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Controls/tests/TestCases.Shared.Tests/Tests/FeatureMatrix/WebViewFeatureTests.cs | Updates cookie-domain assertion to match the new example.com-based URL source. |
| src/Controls/tests/TestCases.HostApp/Issues/XFIssue/Issue4720.cs | Replaces the WebView URL used by the Issue4720 repro page with an example.com URL. |
| src/Controls/tests/TestCases.HostApp/Issues/Issue21846Modal.xaml | Updates modal WebView source URL to www.example.com. |
| src/Controls/tests/TestCases.HostApp/Issues/Issue12134.cs | Updates cookie domain and WebView navigation URL from dotnet.microsoft.com to example.com. |
| src/Controls/tests/TestCases.HostApp/FeatureMatrix/WebView/WebViewOptionsPage.xaml.cs | Replaces button-driven URLs and embedded HTML navigation links with example.com variants for WebView feature testing. |
| src/Controls/tests/TestCases.Mac.Tests/snapshots/mac/Issue16918Test.png | Updates Mac snapshot baseline for Issue16918Test. |
Comment on lines
52
to
55
| _viewModel.Source = new UrlWebViewSource | ||
| { | ||
| Url = "https://www.microsoft.com" | ||
| Url = "https://www.example.com" | ||
| }; |
Comment on lines
+91
to
+92
| <p><a href='https://www.example.com'>Go to Page 2 (Microsoft)</a></p> | ||
| <p><a href='https://www.example.com'>Go to Page 3 (GitHub)</a></p> |
kubaflo
approved these changes
Jun 26, 2026
This was referenced Jun 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment whether this change resolves your issue. Thank you!
Description of Change
Test URL and domain updates:
microsoft.com,github.com, anddotnet.microsoft.com) toexample.comvariants in both code and XAML files. [1] [2] [3] [4]example.cominstead of external domains.Cookie handling and assertions:
example.comas the cookie domain, replacing previous references todotnet.microsoft.comandgithub.com. [1] [2]Update Mac UI test snapshot baseline for Issue16918Test
Issue16918Teston Mac, resolving the CI failure caused by an outdated reference image.