docs: Update branch reference from net10.0 to net11.0 in DEVELOPMENT.md#35193
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 35193Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 35193" |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the contributor development documentation to point new feature/public API work to the active net11.0 feature branch instead of the stale net10.0 reference.
Changes:
- Update the “What branch should I use?” section to link to
net11.0for new features/API changes.
Collaborator
|
/review |
Contributor
|
✅ Expert Code Review completed successfully! |
Contributor
There was a problem hiding this comment.
Expert Code Review — PR #35193
3 independent reviewers analyzed this documentation change using adversarial consensus.
Findings
| # | Severity | File | Finding | Consensus |
|---|---|---|---|---|
| 1 | 🟡 MODERATE | .github/copilot-instructions.md |
Lines ~21 and ~143 still reference net10.0 as the feature branch. This creates an inconsistency: DEVELOPMENT.md now says net11.0 while copilot-instructions.md still says net10.0. The Copilot CLI agent reads the latter for branching decisions. |
2/3 reviewers |
Discarded findings:
- Merge workflow may need
net11.0update — discarded after follow-up (1/3 + 0/2). Both follow-up reviewers confirmedgithub-merge-flow-net11.jsoncand.github/workflows/merge-main-to-net11.ymlalready exist; thenet10.0workflow is still active for LTS servicing.
CI & Test Coverage
This is a documentation-only change (1 markdown file, 1 line). No CI build or test coverage is required.
Summary
The DEVELOPMENT.md change itself is correct. The one actionable finding is that .github/copilot-instructions.md carries the identical branching guidance and should be updated in this PR to avoid inconsistency.
Methodology: 3 independent reviewers with adversarial consensus. Disputed findings verified via targeted follow-up.
Generated by Expert Code Review for issue #35193 · ● 7.4M
Addresses review feedback: keep branching guidance consistent with DEVELOPMENT.md so the Copilot CLI agent and human contributors are both directed to net11.0 for new features and API changes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Collaborator
|
Addressed review feedback from github-actions[bot]:
Other Commit: 6998f19 |
kubaflo
approved these changes
Apr 28, 2026
kubaflo
approved these changes
Apr 28, 2026
PureWeen
added a commit
that referenced
this pull request
Apr 29, 2026
…md (#35193) > [!NOTE] > Are you waiting for the changes in this PR to be merged? > It would be very helpful if you could [test the resulting artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from this PR and let us know in a comment if this change resolves your issue. Thank you! ## Summary Update `.github/DEVELOPMENT.md` to reference `net11.0` instead of `net10.0` for new features and API changes. The `net11.0` branch is now the active feature branch. The stale `net10.0` reference would send contributors to the wrong branch. --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Jakub Florkowski <kubaflo123@gmail.com>
github-actions Bot
added a commit
that referenced
this pull request
May 6, 2026
…md (#35193) > [!NOTE] > Are you waiting for the changes in this PR to be merged? > It would be very helpful if you could [test the resulting artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from this PR and let us know in a comment if this change resolves your issue. Thank you! ## Summary Update `.github/DEVELOPMENT.md` to reference `net11.0` instead of `net10.0` for new features and API changes. The `net11.0` branch is now the active feature branch. The stale `net10.0` reference would send contributors to the wrong branch. --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Jakub Florkowski <kubaflo123@gmail.com>
github-actions Bot
added a commit
that referenced
this pull request
May 25, 2026
…md (#35193) > [!NOTE] > Are you waiting for the changes in this PR to be merged? > It would be very helpful if you could [test the resulting artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from this PR and let us know in a comment if this change resolves your issue. Thank you! ## Summary Update `.github/DEVELOPMENT.md` to reference `net11.0` instead of `net10.0` for new features and API changes. The `net11.0` branch is now the active feature branch. The stale `net10.0` reference would send contributors to the wrong branch. --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Jakub Florkowski <kubaflo123@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Summary
Update
.github/DEVELOPMENT.mdto referencenet11.0instead ofnet10.0for new features and API changes.The
net11.0branch is now the active feature branch. The stalenet10.0reference would send contributors to the wrong branch.