[NET11.0] Provided Fill property support for BoxView control by NirmalKumarYuvaraj · Pull Request #31789 · dotnet/maui

NirmalKumarYuvaraj · 2025-09-26T12:09:26Z

Note

Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!

Description of Change

This pull request adds support for the Fill property to the BoxView control, allowing it to be filled with any Brush (including gradients), not just a solid color. It introduces the necessary property, binding, event handling, and updates to tests and sample code to demonstrate and validate the new functionality.

The most important changes are:

BoxView Fill Property Implementation:

Added a new bindable property FillProperty and corresponding Fill getter/setter to BoxView, enabling the use of any Brush (such as gradients) to fill the box. The property includes logic to manage event subscriptions for brush changes and resource updates. (src/Controls/src/Core/BoxView/BoxView.cs) [1] [2] [3] [4]
Updated the implementation of the IShapeView.Fill property to prioritize the new Fill property over the existing Color property. (src/Controls/src/Core/BoxView/BoxView.cs)

Event Handling and Resource Management:

Introduced the WeakBrushChangedProxy helper class to manage weak event subscriptions for brush property changes, ensuring proper resource cleanup and preventing memory leaks. (src/Controls/src/Core/Internals/WeakEventProxy.cs, moved from src/Controls/src/Core/Shapes/Shape.cs) [1] [2]
Ensured event handlers and resource listeners are added/removed as the Fill property changes, and cleaned up in the BoxView destructor. (src/Controls/src/Core/BoxView/BoxView.cs) [1] [2]

Public API Updates:

Registered the new Fill property and its accessors in the public API files for all supported platforms. [1] [2] [3] [4] [5] [6]

Test and Sample Enhancements:

Updated the BoxView sample view model and test page to support and demonstrate the new Fill property, including options for solid, linear, and radial gradient fills, and corresponding UI controls. (src/Controls/tests/TestCases.HostApp/FeatureMatrix/BoxView/BoxViewControlPage.xaml, src/Controls/tests/TestCases.HostApp/FeatureMatrix/BoxView/BoxViewViewModel.cs) [1] [2] [3] [4] [5]

Code Cleanup:

Removed the unused System.ComponentModel import and relocated the WeakBrushChangedProxy class from Shape.cs to a more appropriate location. (src/Controls/src/Core/BoxView/BoxView.cs, src/Controls/src/Core/Shapes/Shape.cs) [1] [2]

Issues Fixed

Fixes #2365

Copilot

Pull Request Overview

This PR adds support for the Fill property to the BoxView control, enabling it to be filled with any Brush (including gradients) instead of just solid colors. The implementation includes proper event handling, resource management, and comprehensive test coverage.

Adds a new Fill property to BoxView that accepts any Brush type
Implements proper event subscription and resource management for brush changes
Updates the IShapeView.Fill implementation to prioritize the new Fill property over the existing Color property

Reviewed Changes

Copilot reviewed 13 out of 23 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
`src/Controls/src/Core/BoxView/BoxView.cs`	Core implementation of the `Fill` property with event handling and resource management
`src/Controls/src/Core/Internals/WeakEventProxy.cs`	Adds `WeakBrushChangedProxy` class for managing brush change subscriptions
`src/Controls/src/Core/Shapes/Shape.cs`	Removes duplicate `WeakBrushChangedProxy` class
`src/Controls/src/Core/PublicAPI/*/PublicAPI.Unshipped.txt`	Updates public API surface for all platforms
`src/Controls/tests/TestCases.HostApp/FeatureMatrix/BoxView/BoxViewViewModel.cs`	Adds view model support for Fill property with gradient brushes
`src/Controls/tests/TestCases.HostApp/FeatureMatrix/BoxView/BoxViewControlPage.xaml`	Updates UI test page with Fill property binding and controls
`src/Controls/tests/TestCases.Shared.Tests/Tests/FeatureMatrix/BoxViewFeatureTests.cs`	Adds new UI tests for Fill property functionality

jsuarezruiz · 2025-09-29T06:53:13Z

/azp run MAUI-UITests-public

azure-pipelines · 2025-09-29T06:53:27Z

Azure Pipelines successfully started running 1 pipeline(s).

jsuarezruiz

Several tests failing on Android:

Around 7-8% difference between snapshots. Could you take a look?

NirmalKumarYuvaraj · 2025-09-30T07:31:11Z

Several tests failing on Android: Around 7-8% difference between snapshots. Could you take a look?

@jsuarezruiz , I have added the pending snaps for android and mac platforms. There was a issue with windows platform , it does not have anything to do with this PR. it was related to shadow (#31821). Fill is working fine in windows also. attaching images for reference.

Solid	Linear	Radial

jsuarezruiz · 2025-10-01T07:39:02Z

/azp run MAUI-UITests-public

azure-pipelines · 2025-10-01T07:39:14Z

Azure Pipelines successfully started running 1 pipeline(s).

jsuarezruiz

Pending snapshot on Windows.

BoxView_CornerRadiusWithOpacityAndShadow

jsuarezruiz · 2025-10-09T14:53:57Z

Pending snapshot on Windows.

BoxView_CornerRadiusWithOpacityAndShadow

Not related with the changes from this PR, but the Shadow not follow the BoxView corners radius.

NirmalKumarYuvaraj · 2025-10-09T17:24:26Z

Pending snapshot on Windows.
BoxView_CornerRadiusWithOpacityAndShadow

Not related with the changes from this PR, but the Shadow not follow the BoxView corners radius.

@jsuarezruiz , yeah need to restrict this test case too.

jsuarezruiz · 2025-10-30T10:55:16Z

/azp run

azure-pipelines · 2025-10-30T10:55:40Z

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz · 2025-10-30T10:58:15Z

 		PathAspect IShapeView.Aspect => PathAspect.None;

-		Paint? IShapeView.Fill => Color?.AsPaint();
+		Paint? IShapeView.Fill => Fill ?? Color?.AsPaint();


The implementation allows both Color and Fill to be set simultaneously, with Fill taking priority. This requires updates in the documentation.

Also, what happens when Fill is cleared?
<BoxView x:Name="box" Color="Red" Fill="{StaticResource MyGradient}" />

Later in code:

box.Fill = null;

Does Red color suddenly appear? Could we have a test?

@jsuarezruiz , when fill is set to null , the color takes over. i have added test case to ensure this.

kubaflo · 2026-03-22T12:59:50Z

@jfversluis do you think it makes sense to add to net11 given that you can use border instead of boxView?

github-actions · 2026-03-26T06:24:55Z

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 31789

Or

Run remotely in PowerShell:

iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 31789"

kubaflo · 2026-04-26T22:00:29Z

@jfversluis the PR looks good, but I'm not sure if this feature is necessary. What do you think?

MauiBot

Expert Review — 6 findings

See inline comments for details.

kubaflo

Could you please review the AI's suggestions?

MauiBot · 2026-05-01T09:53:07Z

⚠️ Merge Conflict Detected — This PR has merge conflicts with its target branch. Please rebase onto the target branch and resolve the conflicts.

NirmalKumarYuvaraj · 2026-05-05T04:58:40Z

@kubaflo , Failures are unrelated. All box view test cases are passed.

kubaflo · 2026-05-05T10:36:30Z

@jfversluis this PR is good to go to net11 if we want this feature

dotnet-policy-service · 2026-05-05T12:53:19Z

🚨 API change(s) detected @davidbritch FYI

dotnet-policy-service · 2026-05-05T12:53:20Z

🚨 API change(s) detected @davidortinau FYI

This pull request introduces a small but important change to the `WebViewEvaluateJavaScriptReturnsCorrectResults` test method by adding a call to `VerifyInternetConnectivity()` at the beginning of the test. This ensures that the test only proceeds if there is an active internet connection, which can help prevent false negatives due to connectivity issues. * Added a call to `VerifyInternetConnectivity()` at the start of the `WebViewEvaluateJavaScriptReturnsCorrectResults` test in `Issue20288.cs` to ensure the test only runs when internet access is available. * Re-saved the correct iOS 18 images for BoxViewFeatureTests due to wrong images being re-saved in this PR: #31789.

dotnet-policy-service Bot added community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration labels Sep 26, 2025

sheiksyedm added the area-drawing Shapes, Borders, Shadows, Graphics, BoxView, custom drawing label Sep 26, 2025

NirmalKumarYuvaraj marked this pull request as ready for review September 26, 2025 12:12

Copilot AI review requested due to automatic review settings September 26, 2025 12:12

Copilot AI reviewed Sep 26, 2025

View reviewed changes

Comment thread src/Controls/src/Core/BoxView/BoxView.cs Outdated

Comment thread src/Controls/tests/TestCases.HostApp/FeatureMatrix/BoxView/BoxViewControlPage.xaml

Comment thread src/Controls/tests/TestCases.HostApp/FeatureMatrix/BoxView/BoxViewControlPage.xaml

jsuarezruiz suggested changes Sep 29, 2025

View reviewed changes

jsuarezruiz suggested changes Oct 9, 2025

View reviewed changes

jsuarezruiz suggested changes Oct 30, 2025

View reviewed changes

NirmalKumarYuvaraj force-pushed the fix-2365 branch from c84fd2d to 239f965 Compare October 31, 2025 07:47

Tamilarasan-Paranthaman force-pushed the fix-2365 branch from 648a912 to 8c86973 Compare March 26, 2026 06:24

Tamilarasan-Paranthaman changed the base branch from net10.0 to net11.0 March 26, 2026 06:24

Tamilarasan-Paranthaman changed the title ~~Provided Fill property support for BoxView control~~ [NET11.0] Provided Fill property support for BoxView control Mar 26, 2026

MauiBot added s/agent-changes-requested AI agent recommends changes - found a better alternative or issues s/agent-fix-win AI found a better alternative fix than the PR s/agent-reviewed PR was reviewed by AI agent workflow (full 4-phase review) labels Mar 29, 2026

This was referenced Mar 30, 2026

The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008

Open

[android-arm64] The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#6408

Closed

github-actions Bot mentioned this pull request Apr 30, 2026

[PR Review Queue] 2026-04-30 #35246

Closed

dotnet deleted a comment from MauiBot Apr 30, 2026

This was referenced Apr 30, 2026

[Android] Issue18896Test screenshot baseline mismatch (MaxItemCount bottom nav change) #34623

Closed

[Android] Issue18896Test screenshot baseline mismatch (MaxItemCount bottom nav change) #34625

Closed

MauiBot reviewed Apr 30, 2026

View reviewed changes

kubaflo requested changes Apr 30, 2026

View reviewed changes

dotnet deleted a comment from MauiBot May 1, 2026

github-actions Bot mentioned this pull request May 5, 2026

[PR Review Queue] 2026-05-05 #35306

Closed

kubaflo approved these changes May 5, 2026

View reviewed changes

jfversluis merged commit 754ba13 into dotnet:net11.0 May 5, 2026
191 of 211 checks passed

jfversluis added the t/breaking 💥 label May 5, 2026

github-actions Bot added this to the .NET 11.0-preview4 milestone May 5, 2026

TamilarasanSF4853 mentioned this pull request May 7, 2026

[Testing] Fixed test failure in net11 branch - 2 #35345

Merged

github-actions Bot locked and limited conversation to collaborators Jun 5, 2026

PureWeen modified the milestones: .NET 11.0-preview4, .NET 11.0-preview5 Jun 10, 2026

Uh oh!

Conversation

NirmalKumarYuvaraj commented Sep 26, 2025

Description of Change

Issues Fixed

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jsuarezruiz commented Sep 29, 2025

Uh oh!

azure-pipelines Bot commented Sep 29, 2025

Uh oh!

jsuarezruiz left a comment

Choose a reason for hiding this comment

Uh oh!

NirmalKumarYuvaraj commented Sep 30, 2025

Uh oh!

jsuarezruiz commented Oct 1, 2025

Uh oh!

azure-pipelines Bot commented Oct 1, 2025

Uh oh!

jsuarezruiz left a comment

Choose a reason for hiding this comment

Uh oh!

jsuarezruiz commented Oct 9, 2025

Uh oh!

NirmalKumarYuvaraj commented Oct 9, 2025

Uh oh!

jsuarezruiz commented Oct 30, 2025

Uh oh!

azure-pipelines Bot commented Oct 30, 2025

Uh oh!

jsuarezruiz Oct 30, 2025

Choose a reason for hiding this comment

Uh oh!

jsuarezruiz Oct 30, 2025

Choose a reason for hiding this comment

Uh oh!

NirmalKumarYuvaraj Oct 31, 2025

Choose a reason for hiding this comment

Uh oh!

kubaflo commented Mar 22, 2026

Uh oh!

github-actions Bot commented Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kubaflo commented Apr 26, 2026

Uh oh!

MauiBot left a comment

Choose a reason for hiding this comment

Expert Review — 6 findings

Uh oh!

kubaflo left a comment

Choose a reason for hiding this comment

Uh oh!

MauiBot commented May 1, 2026

Uh oh!

NirmalKumarYuvaraj commented May 5, 2026

Uh oh!

kubaflo commented May 5, 2026

Uh oh!

Uh oh!

dotnet-policy-service Bot commented May 5, 2026

Uh oh!

dotnet-policy-service Bot commented May 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

github-actions Bot commented Mar 26, 2026 •

edited

Loading