Skip to content

Commit 45d2f6f

Browse files
Rename the same suffix tests and drop the issue reference
As asked in review.
1 parent 1df2b59 commit 45d2f6f

2 files changed

Lines changed: 2 additions & 3 deletions

File tree

test/Microsoft.Data.Analysis.Tests/DataFrameTests.Join.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ public void TestJoin()
8787
[InlineData(JoinAlgorithm.Right)]
8888
[InlineData(JoinAlgorithm.FullOuter)]
8989
[InlineData(JoinAlgorithm.Inner)]
90-
public void TestJoin_SameSuffixOnBothSides_Issue6128(JoinAlgorithm joinAlgorithm)
90+
public void TestJoin_ColumnNamesCollide_ThrowsOnSameSuffixOnBothSides(JoinAlgorithm joinAlgorithm)
9191
{
9292
DataFrame left = MakeDataFrameWithNumericColumns(3, false);
9393
DataFrame right = MakeDataFrameWithNumericColumns(4, false);

test/Microsoft.Data.Analysis.Tests/DataFrameTests.Merge.cs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1014,8 +1014,7 @@ public void TestMerge_CorrectColumnTypes()
10141014
}
10151015

10161016
[Fact]
1017-
//Issue 6128
1018-
public void TestMerge_SameSuffixOnBothSides()
1017+
public void TestMerge_ColumnNamesCollide_ThrowsOnSameSuffixOnBothSides()
10191018
{
10201019
DataFrame left = MakeDataFrameWithNumericColumns(3, false);
10211020
DataFrame right = MakeDataFrameWithNumericColumns(4, false);

0 commit comments

Comments
 (0)