You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Code change is fine, but we should target main ? Actually, I need to check there whether we should be targeting main or dev - I still haven't fully sunk into the release cycle "here" (dotnet/extensions).
Code change is fine, but we should target main ? Actually, I need to check there whether we should be targeting main or dev - I still haven't fully sunk into the release cycle "here" (dotnet/extensions).
I picked what seemed like the latest preview version, but can did it again easily since it's literally just 2 chars 😅
Let me know if I do that or you prefer to rebase etc.
Almost certainly main - you may be able to simply edit the PR to retarget as long as that doesn't try to bring over all the intermediate commits - or it may be easier to redo the change! I need to check with @joperezr on what the process is meant to be for the other branches.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Microsoft Reviewers: Open in CodeFlow