Clean-up Versions.props files - #3469
Merged
Merged
Conversation
These clean-ups are possible now that we automation updates Version.Details.props instead and that we do centralized branding via the VMR
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR cleans up Versions.props files across multiple repositories by standardizing formatting, removing obsolete properties, and simplifying version control now that automation updates Version.Details.props and branding is centralized via the VMR.
Key changes:
- Removed XML declarations and simplified Project elements across all files
- Removed conditional Import statements for
Version.Details.props - Replaced
StabilizePackageVersionlogic with simplerDotNetFinalVersionKindproperty - Added standardized comments for version properties
- Removed various obsolete properties like
FlagNetStandard1XDependenciesandUsingToolNetFrameworkReferenceAssemblies
Reviewed Changes
Copilot reviewed 29 out of 29 changed files in this pull request and generated 18 comments.
Show a summary per file
| File | Description |
|---|---|
| src/xdt/eng/Versions.props | Added PreReleaseVersionIteration, collapsed DotNetFinalVersionKind formatting, added Arcade features comment |
| src/wpf/eng/Versions.props | Simplified Project element, removed conditional Import, added DotNetFinalVersionKind comment, improved whitespace |
| src/winforms/eng/Versions.props | Simplified Project element, removed StabilizePackageVersion logic, standardized comments and whitespace |
| src/windowsdesktop/eng/Versions.props | Collapsed DotNetFinalVersionKind to single line |
| src/vstest/eng/Versions.props | Removed XML declaration, added version properties, reorganized PropertyGroups, removed FlagNetStandard1XDependencies |
| src/templating/eng/Versions.props | Removed StabilizePackageVersion logic, simplified PreReleaseVersionLabel calculation, removed FlagNetStandard1XDependencies |
| src/symreader/eng/Versions.props | Changed PreReleaseVersionLabel from beta to alpha, added version properties and Arcade features comment |
| src/sourcelink/eng/Versions.props | Changed VersionPrefix from 11.0.0 to 11.0.100, changed PreReleaseVersionLabel from beta to alpha, removed FlagNetStandard1XDependencies |
| src/source-build-reference-packages/eng/Versions.props | Removed conditional Import, improved comments and whitespace |
| src/sdk/eng/Versions.props | Removed MSBuildAllProjects, reorganized version properties, removed StabilizePackageVersion logic, removed UsingToolNetFrameworkReferenceAssemblies and FlagNetStandard1XDependencies |
| src/scenario-tests/eng/Versions.props | Removed conditional Import, improved whitespace |
| src/runtime/eng/Versions.props | Added version properties, reorganized PropertyGroups, removed StabilizePackageVersion logic, removed FlagNetStandard1XDependencies |
| src/roslyn/eng/Versions.props | Removed XML declaration and license comment, simplified Roslyn version comment, improved whitespace, removed FlagNetStandard1XDependencies |
| src/razor/eng/Versions.props | Simplified Project element, merged PropertyGroups, removed StabilizePackageVersion logic |
| src/nuget-client/eng/Versions.props | Removed XML declaration, removed conditional Import, improved whitespace |
| src/msbuild/eng/Versions.props | Removed XML declaration and copyright, removed conditional Import, standardized comments, improved whitespace |
| src/fsharp/eng/Versions.props | Removed conditional Import, reorganized Arcade features comment, improved whitespace |
| src/emsdk/eng/Versions.props | Simplified Project element, inlined VersionPrefix calculation, removed StabilizePackageVersion logic |
| src/efcore/eng/Versions.props | Removed conditional Import, added DotNetFinalVersionKind, removed StabilizePackageVersion logic, simplified IsServicingBuild usage |
| src/diagnostics/eng/Versions.props | Removed conditional Import, added version properties, reorganized PropertyGroups, removed FlagNetStandard1XDependencies, improved whitespace |
| src/diagnostics/Directory.Build.props | Moved RepositoryUrl property from eng/Versions.props |
| src/deployment-tools/eng/Versions.props | Removed conditional Import, removed ProductVersion and comments, removed StabilizePackageVersion logic |
| src/command-line-api/eng/Versions.props | Removed conditional Import, collapsed DotNetFinalVersionKind formatting, improved whitespace |
| src/cecil/eng/Versions.props | Removed XML declaration, removed conditional Import, added Arcade features comment, improved whitespace |
| src/aspnetcore/eng/Versions.props | Removed conditional Import, removed comment about automation, removed StabilizePackageVersion logic, improved whitespace |
| src/arcade/eng/Versions.props | Removed conditional Import, removed FlagNetStandard1XDependencies and NETStandardLibraryVersion, improved comments and whitespace |
| repo-projects/xdt.proj | Added AllowDotNetFinalVersionKindOverride property |
| repo-projects/symreader.proj | Added AllowDotNetFinalVersionKindOverride property |
| repo-projects/sourcelink.proj | Added AllowDotNetFinalVersionKindOverride property |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
akoeplinger
approved these changes
Nov 20, 2025
ViktorHofer
enabled auto-merge (squash)
November 20, 2025 10:41
T-Gro
approved these changes
Nov 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These clean-ups are possible now that automation updates Version.Details.props instead and that we do centralized branding via the VMR