Single-quote OData strings within parentheses syntax #1153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+538
to
+545
| foreach ( var parameter in function.Parameters ) | ||
| { | ||
| if ( parameter.Type.IsString() ) | ||
| { | ||
| names ??= []; | ||
| names.Add( parameterMappings[parameter.Name] ); | ||
| } | ||
| } |
Check notice
Code scanning / CodeQL
Missed opportunity to use Where Note
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI about 12 hours ago
In general terms, to fix this, replace the explicit in-loop if-statement filtering (if (condition) { ... }) with filtration of the enumeration using LINQ's Where before entering the loop. Specifically, for the loop at line 538:
foreach ( var parameter in function.Parameters )
{
if ( parameter.Type.IsString() )
{
names ??= [];
names.Add( parameterMappings[parameter.Name] );
}
}should become:
foreach ( var parameter in function.Parameters.Where(p => p.Type.IsString()) )
{
names ??= [];
names.Add( parameterMappings[parameter.Name] );
}This makes it clear that we're only iterating over parameters with Type.IsString(). To implement the change, you'll need to add using System.Linq; if it's not already present. Only code shown may be modified: you may add the import at the top if and only if it's missing in the lines shown.
Suggested changeset
1
src/AspNetCore/OData/src/Asp.Versioning.OData.ApiExplorer/ApiExplorer/ODataApiDescriptionProvider.cs
| @@ -17,6 +17,7 @@ | ||
| using System.Diagnostics.CodeAnalysis; | ||
| using System.Runtime.CompilerServices; | ||
| using System.Text; | ||
| using System.Linq; | ||
| using static ODataMetadataOptions; | ||
| using static System.StringComparison; | ||
| using Opts = Microsoft.Extensions.Options.Options; | ||
| @@ -535,13 +536,10 @@ | ||
| IDictionary<string, string> parameterMappings, | ||
| ref HashSet<string>? names ) | ||
| { | ||
| foreach ( var parameter in function.Parameters ) | ||
| foreach ( var parameter in function.Parameters.Where(p => p.Type.IsString()) ) | ||
| { | ||
| if ( parameter.Type.IsString() ) | ||
| { | ||
| names ??= []; | ||
| names.Add( parameterMappings[parameter.Name] ); | ||
| } | ||
| names ??= []; | ||
| names.Add( parameterMappings[parameter.Name] ); | ||
| } | ||
| } | ||
|
|
Copilot is powered by AI and may make mistakes. Always verify output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Single-quote OData strings
Description
Fixes up OData route templates during API exploration for OData strings that are within the parentheses syntax. This typically applies to composite keys and functions.