Skip to content

Enable MemoryDiagnoser on Legacy Mono - #2459

Merged
timcassell merged 8 commits into
dotnet:masterfrom
MichalPetryka:patch-3
Nov 15, 2023
Merged

Enable MemoryDiagnoser on Legacy Mono#2459
timcassell merged 8 commits into
dotnet:masterfrom
MichalPetryka:patch-3

Conversation

@MichalPetryka

@MichalPetryka MichalPetryka commented Nov 2, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

This enables MemoryDiagnoser on Legacy Mono (since it provides GetAllocatedBytesForCurrentThread) and makes it more resilient to errors.

@MichalPetryka
Enable MemoryDiagnoser on Legacy Mono
5e2aafb 
This enables MemoryDiagnoser on Legacy Mono and makes it more resilient to errors.
@MichalPetryka
MichalPetryka marked this pull request as draft November 2, 2023 01:54
timcassell
timcassell reviewed Nov 2, 2023
View reviewed changes
Comment thread src/BenchmarkDotNet/Engines/GcStats.cs Outdated
timcassell
timcassell reviewed Nov 2, 2023
View reviewed changes
Comment thread src/BenchmarkDotNet/Engines/GcStats.cs
timcassell
timcassell reviewed Nov 3, 2023
View reviewed changes
Comment thread src/BenchmarkDotNet/Engines/GcStats.cs Outdated
@MichalPetryka @timcassell
Update src/BenchmarkDotNet/Engines/GcStats.cs
2be7a53 
Co-authored-by: Tim Cassell <35501420+timcassell@users.noreply.github.com>
@timcassell

timcassell commented Nov 12, 2023

Copy link
Copy Markdown
Collaborator

@MichalPetryka Is this good to go? It's still in draft.

@MichalPetryka
MichalPetryka marked this pull request as ready for review November 15, 2023 21:13
@MichalPetryka

MichalPetryka commented Nov 15, 2023

Copy link
Copy Markdown
Contributor Author

Is this good to go?

I wanted to check with a test benchmark and forgot about it, it seems to work fine:

| Method | Job                | Runtime            | Mean      | Error     | StdDev    | Gen0   | Allocated |
|------- |------------------- |------------------- |----------:|----------:|----------:|-------:|----------:|
| Alloc  | .NET 8.0           | .NET 8.0           | 11.401 ns | 1.2076 ns | 3.5605 ns | 0.0255 |      40 B |
| Alloc  | .NET Framework 4.8 | .NET Framework 4.8 |  6.179 ns | 0.6341 ns | 1.8597 ns | 0.0255 |      40 B |
| Alloc  | Mono               | Mono               | 16.793 ns | 1.1951 ns | 3.5238 ns | 0.0115 |      48 B |
| Alloc  | Mono with .NET 8.0 | Mono with .NET 8.0 | 18.935 ns | 0.3219 ns | 0.3832 ns | 0.0115 |      48 B |

@timcassell

timcassell commented Nov 15, 2023

Copy link
Copy Markdown
Collaborator

Yep, I tested it with my own benchmarks also, and it all seems good to me. Thanks @MichalPetryka!

@timcassell
timcassell merged commit fc7afed into dotnet:master Nov 15, 2023
@timcassell timcassell added this to the v0.13.11 milestone Nov 15, 2023
This was referenced Aug 1, 2025
Merged
Open
This was referenced Aug 17, 2025
Closed
Closed
@dependabot dependabot Bot mentioned this pull request Sep 3, 2025
Closed
This was referenced Sep 15, 2025
Closed
Closed
Closed
Closed
Closed
This was referenced Nov 30, 2025
Merged
Open
Open
@dependabot dependabot Bot mentioned this pull request Dec 10, 2025
Open
@dependabot dependabot Bot mentioned this pull request Jan 8, 2026
Open
@dependabot dependabot Bot mentioned this pull request Feb 5, 2026
Open
This was referenced Mar 6, 2026
Closed
Closed
Open
This was referenced Apr 3, 2026
Open
Merged
This was referenced Apr 20, 2026
Merged
Open
Open
This was referenced Apr 27, 2026
Open
Open
Open
Open
This was referenced May 14, 2026
Open
Open
This was referenced May 21, 2026
Open
Closed
Open
This was referenced Jun 8, 2026
Merged
Merged
This was referenced Jun 25, 2026
Closed
Merged
This was referenced Jul 14, 2026
Open
Open
@dependabot dependabot Bot mentioned this pull request Aug 17, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timcassell timcassell timcassell approved these changes

Assignees

No one assigned

Labels

Area:Diagnosers

Projects

None yet

Milestone

v0.13.11

Development

Successfully merging this pull request may close these issues.

2 participants

@MichalPetryka @timcassell