Skip to content

Conversation

@MakiWolf
Copy link

Remove nuget package Microsoft.VisualStudio.CodingConventions
Since #112 where a package is not avilable any more, I have commented that code out that it is building now without it. Maybe it is useful? Hope I commented out everything where it is downloaded. There needs to be much to comment out, but do we have an alternative? I have not tested if there are crashes and what features are missing.

@knocte
Copy link
Member

knocte commented Jul 24, 2023

@MakiWolf thanks for your PR. Can you please:

  • Use multi-line-style C# comments (with /* instead of //) when commenting more than one line. This way you don't introduce git-blame noise, in case any of the lines need to be re-enabled later.
  • Enable GitHubActions on your fork, so that we can see the CI status of your changes (after enabling GitHubActions, you need to repush this branch again).

@MakiWolf
Copy link
Author

@knocte Thank you for feedback.

  • Use multi-line-style C# comments (with /* instead of //) when commenting more than one line. This way you don't introduce git-blame noise, in case any of the lines need to be re-enabled later.

I will do this in future.

  • Enable GitHubActions on your fork, so that we can see the CI status of your changes (after enabling GitHubActions, you need to repush this branch again).

I have turned on github actions and here is the output: https://github.com/MakiWolf/dotdevelop/actions/runs/5647216462

@knocte
Copy link
Member

knocte commented Jul 24, 2023

I will do this in future.

You can still change it in this PR and if whoever merges it squashes commits, then the git-blame-noise is averted.

@MakiWolf
Copy link
Author

You can still change it in this PR and if whoever merges it squashes commits, then the git-blame-noise is averted.

@knocte I have made a commit now and changed this. But please note that this PR is experimental.

@MakiWolf MakiWolf changed the title Nugetpackageremove Microsoft.VisualStudio.CodingConventions comment out some nuget packages Sep 4, 2023
@MakiWolf MakiWolf changed the title comment out some nuget packages Draft: comment out some nuget packages Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants