Skip to content

Upgrade httpclient #2293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Sineaggi wants to merge 4 commits into from
Closed

Upgrade httpclient #2293

Sineaggi wants to merge 4 commits into from

Conversation

@Sineaggi
Copy link
Contributor

@Sineaggi Sineaggi commented Jan 10, 2024 •
edited
Loading

Upgrade httpclient5 to latest version.

@strangelookingnerd strangelookingnerd mentioned this pull request Jan 16, 2024
Closed
@Sineaggi Sineaggi marked this pull request as ready for review February 27, 2024 22:15
@Sineaggi Sineaggi requested a review from a team as a code owner February 27, 2024 22:15
@Sineaggi
Copy link
Contributor Author

Sineaggi commented Aug 3, 2024

If #2272 was merged, we could close this.

@Sineaggi
Update pom.xml
bf31f51 
Upgrade httpclient to latest version.
@strangelookingnerd strangelookingnerd mentioned this pull request Oct 22, 2024
Merged
1 task
@brian-mulier-p
Copy link

brian-mulier-p commented Oct 24, 2024

FYI there seems to be an issue on the v5.4 of this dep in case you're planning to update to it... Was a nightmare to debug but we had a transitive dependency from opensearch client that brought this dep to v5.4 and our whole docker is broken due to unability to communicate with the socket

org.apache.hc.client5.http.HttpHostConnectException: Connect to unix://localhost:2375 [localhost/127.0.0.1] failed: Connection refused
java.lang.RuntimeException: org.apache.hc.client5.http.HttpHostConnectException: Connect to unix://localhost:2375 [localhost/127.0.0.1] failed: Connection refused
	at com.github.dockerjava.httpclient5.ApacheDockerHttpClientImpl.execute(ApacheDockerHttpClientImpl.java:210)
	at com.github.dockerjava.httpclient5.ApacheDockerHttpClient.execute(ApacheDockerHttpClient.java:9)
	at com.github.dockerjava.core.DefaultInvocationBuilder.execute(DefaultInvocationBuilder.java:228)
	at com.github.dockerjava.core.DefaultInvocationBuilder.lambda$executeAndStream$1(DefaultInvocationBuilder.java:269)
	at java.base/java.lang.Thread.run(Thread.java:1583)
Caused by: org.apache.hc.client5.http.HttpHostConnectException: Connect to unix://localhost:2375 [localhost/127.0.0.1] failed: Connection refused
	at java.base/sun.nio.ch.Net.pollConnect(Native Method)
	at java.base/sun.nio.ch.Net.pollConnectNow(Net.java:682)
	at java.base/sun.nio.ch.NioSocketImpl.timedFinishConnect(NioSocketImpl.java:542)
	at java.base/sun.nio.ch.NioSocketImpl.connect(NioSocketImpl.java:592)
	at java.base/java.net.SocksSocketImpl.connect(SocksSocketImpl.java:327)
	at java.base/java.net.Socket.connect(Socket.java:751)
	at org.apache.hc.client5.http.impl.io.DefaultHttpClientConnectionOperator.connect(DefaultHttpClientConnectionOperator.java:216)
	at org.apache.hc.client5.http.impl.io.PoolingHttpClientConnectionManager.connect(PoolingHttpClientConnectionManager.java:490)
	at org.apache.hc.client5.http.impl.classic.InternalExecRuntime.connectEndpoint(InternalExecRuntime.java:164)
	at org.apache.hc.client5.http.impl.classic.InternalExecRuntime.connectEndpoint(InternalExecRuntime.java:174)
	at org.apache.hc.client5.http.impl.classic.ConnectExec.execute(ConnectExec.java:144)
	at org.apache.hc.client5.http.impl.classic.ExecChainElement.execute(ExecChainElement.java:51)
	at org.apache.hc.client5.http.impl.classic.ProtocolExec.execute(ProtocolExec.java:192)
	at org.apache.hc.client5.http.impl.classic.ExecChainElement.execute(ExecChainElement.java:51)
	at org.apache.hc.client5.http.impl.classic.ContentCompressionExec.execute(ContentCompressionExec.java:150)
	at org.apache.hc.client5.http.impl.classic.ExecChainElement.execute(ExecChainElement.java:51)
	at org.apache.hc.client5.http.impl.classic.HttpRequestRetryExec.execute(HttpRequestRetryExec.java:113)
	at org.apache.hc.client5.http.impl.classic.ExecChainElement.execute(ExecChainElement.java:51)
	at org.apache.hc.client5.http.impl.classic.RedirectExec.execute(RedirectExec.java:110)
	at org.apache.hc.client5.http.impl.classic.ExecChainElement.execute(ExecChainElement.java:51)
	at org.apache.hc.client5.http.impl.classic.InternalHttpClient.doExecute(InternalHttpClient.java:174)
	at org.apache.hc.client5.http.impl.classic.CloseableHttpClient.execute(CloseableHttpClient.java:87)
	at com.github.dockerjava.httpclient5.ApacheDockerHttpClientImpl.execute(ApacheDockerHttpClientImpl.java:206)
	... 4 common frames omitted

@basil
Copy link

basil commented Oct 28, 2024

FYI there seems to be an issue on the v5.4 of this dep in case you're planning to update to it... Was a nightmare to debug but we had a transitive dependency from opensearch client that brought this dep to v5.4 and our whole docker is broken due to unability to communicate with the socket

#2363 FTR

@eddumelendez
Copy link
Member

eddumelendez commented Apr 1, 2025

Thanks for your contribution, @Sineaggi. This has been addressed via #2364

@Sineaggi Sineaggi deleted the upgrade-httpclient branch April 1, 2025 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Sineaggi @brian-mulier-p @basil @eddumelendez