Skip to content

Implicit jackson config #1276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bsideup merged 11 commits into from
Nov 20, 2019
Merged

Implicit jackson config #1276

bsideup merged 11 commits into from
Nov 20, 2019

Conversation

@bsideup
Copy link
Member

@bsideup bsideup commented Nov 20, 2019 •
edited by marcuslinke
Loading

Since #1275 is merged, we now should remove explicit @JsonIgnoreProperties and @JsonInclude since we now can set them globally.

This is a part of the ongoing effort to reduce the Jackson usage (and maybe even remove the direct dependency from the api module)

This change is Reviewable

@bsideup bsideup added this to the 3.2.0 milestone Nov 20, 2019
@bsideup bsideup requested a review from KostyaSha November 20, 2019 07:32
@codecov-io
Copy link

codecov-io commented Nov 20, 2019 •
edited
Loading

Codecov Report

Merging #1276 into master will increase coverage by 15.65%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #1276       +/-   ##
==========================================
+ Coverage   59.34%     75%   +15.65%     
==========================================
  Files         441       1      -440     
  Lines        8692      16     -8676     
  Branches      528       0      -528     
==========================================
- Hits         5158      12     -5146     
+ Misses       3246       3     -3243     
+ Partials      288       1      -287
Impacted Files Coverage Δ
.../dockerjava/api/model/ContainerSpecPrivileges.java
...ockerjava/core/command/RemoveSwarmNodeCmdImpl.java
...ithub/dockerjava/netty/NettyInvocationBuilder.java
...va/com/github/dockerjava/core/GoLangFileMatch.java
...a/com/github/dockerjava/api/model/BindOptions.java
.../github/dockerjava/api/model/PullResponseItem.java
...om/github/dockerjava/core/command/PingCmdImpl.java
...ub/dockerjava/core/command/CreateImageCmdImpl.java
.../github/dockerjava/jaxrs/KillContainerCmdExec.java
.../dockerjava/api/command/CreateNetworkResponse.java
... and 432 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41eea38...0522a79. Read the comment docs.

@bsideup bsideup merged commit 066f268 into master Nov 20, 2019
@bsideup bsideup deleted the implicit_jackson_config branch November 20, 2019 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KostyaSha KostyaSha KostyaSha approved these changes

Assignees

No one assigned

Labels

type/enhancement

Projects

None yet

Milestone

3.2.0

Development

Successfully merging this pull request may close these issues.

4 participants

@bsideup @codecov-io @KostyaSha