Skip to content

image/list: Show collapsed tree by default #6566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thaJeztah merged 5 commits into from
Oct 31, 2025
Merged

image/list: Show collapsed tree by default #6566

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c41815f
image/list: Show collapsed tree by default
vvoland Oct 15, 2025
631f32e
images/list: Add print ambiguous warning for tree
vvoland Oct 15, 2025
f6feef8
image/test: Fix `go test` args being used by CLI commands
vvoland Oct 15, 2025
5836040
Update golden files
vvoland Oct 15, 2025
6fa5900
image/tree: Remove longest->shortest sort
vvoland Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
image/tree: Remove longest->shortest sort 
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
  • Loading branch information
@vvoland
vvoland committed Oct 31, 2025
commit 6fa59003391ed24343d463a3e4bb667144695c3e
11 changes: 1 addition & 10 deletions cli/command/image/tree.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import (
"fmt"
"os"
"slices"
"sort"
"strings"

"github.com/containerd/platforms"
Expand Down Expand Up @@ -422,15 +421,7 @@ func printNames(out tui.Output, headers []imgColumn, img topImage, color, untagg
_, _ = fmt.Fprint(out, headers[0].Print(untaggedColor, "<untagged>"))
}

// TODO: Replace with namesLongestToShortest := slices.SortedFunc(slices.Values(img.Names))
// once we move to Go 1.23.
namesLongestToShortest := make([]string, len(img.Names))
copy(namesLongestToShortest, img.Names)
sort.Slice(namesLongestToShortest, func(i, j int) bool {
return len(namesLongestToShortest[i]) > len(namesLongestToShortest[j])
})

for nameIdx, name := range namesLongestToShortest {
for nameIdx, name := range img.Names {
// Don't limit first names to the column width because only the last
// name will be printed alongside other columns.
if nameIdx < len(img.Names)-1 {
Expand Down
Loading