feat: add language attribute to RedisConfig#953
Merged
Conversation
Signed-off-by: AnneY <evangeline-lun@foxmail.com>
Signed-off-by: AnneY <evangeline-lun@foxmail.com>
Signed-off-by: AnneY <evangeline-lun@foxmail.com>
Codecov ReportBase: 83.00% // Head: 85.20% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #953 +/- ##
==========================================
+ Coverage 83.00% 85.20% +2.20%
==========================================
Files 155 155
Lines 8049 8050 +1
==========================================
+ Hits 6681 6859 +178
+ Misses 1368 1191 -177
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: AnneY <evangeline-lun@foxmail.com>
Signed-off-by: AnneY <evangeline-lun@foxmail.com>
|
📝 Docs are deployed on https://ft-feat-redis-chinese--jina-docs.netlify.app 🎉 |
JoanFM
requested changes
Dec 20, 2022
| the closest Document objects for each of the queries in `query`. | ||
| """ | ||
| query = np.array(query).astype(np.float) | ||
| query = np.array(query).astype(np.float32) |
Contributor
Author
There was a problem hiding this comment.
numpy has a new release three days ago and its version is updated to 1.24.0 in ci, where np.float and np.int is no longer available
JoanFM
approved these changes
Dec 20, 2022
bwanglzu
pushed a commit
that referenced
this pull request
Dec 21, 2022
* feat: add language to RedisConfig Signed-off-by: AnneY <evangeline-lun@foxmail.com> * test: add test for redis chinese support Signed-off-by: AnneY <evangeline-lun@foxmail.com> * docs: add language to RedisConfig Signed-off-by: AnneY <evangeline-lun@foxmail.com> * fix: numpy is updated to 1.24.0 Signed-off-by: AnneY <evangeline-lun@foxmail.com> * fix: increase timeout-minutes for oldproto Signed-off-by: AnneY <evangeline-lun@foxmail.com> Signed-off-by: AnneY <evangeline-lun@foxmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: AnneY evangeline-lun@foxmail.com
Goals:
Attribute
languageis added to RedisConfig, so that user can search in certain language, especially chinese.#952