Skip to content

chore: add different python version to ci#935

Merged
JoanFM merged 8 commits into
mainfrom
chore-updage-cicd
Dec 16, 2022
Merged

chore: add different python version to ci#935
JoanFM merged 8 commits into
mainfrom
chore-updage-cicd

Conversation

@samsja

@samsja samsja commented Dec 13, 2022

Copy link
Copy Markdown
Member

Signed-off-by: Sami Jaghouar sami.jaghouar@hotmail.fr

What this pr do

  • bump to python 3.8 for testing
  • check import and install on different python version

Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr>
Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr>
@codecov-commenter

codecov-commenter commented Dec 13, 2022

Copy link
Copy Markdown

Codecov Report

Base: 88.47% // Head: 83.58% // Decreases project coverage by -4.88% ⚠️

Coverage data is based on head (4e50645) compared to base (6ec0cf5).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #935      +/-   ##
==========================================
- Coverage   88.47%   83.58%   -4.89%     
==========================================
  Files         155      155              
  Lines        8009     8048      +39     
==========================================
- Hits         7086     6727     -359     
- Misses        923     1321     +398     
Flag Coverage Δ
docarray 83.58% <ø> (-4.89%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
docarray/array/mixins/embed.py 9.89% <0.00%> (-82.42%) ⬇️
docarray/array/mixins/evaluation.py 8.91% <0.00%> (-79.55%) ⬇️
docarray/array/mixins/reduce.py 26.92% <0.00%> (-73.08%) ⬇️
docarray/array/mixins/io/dataframe.py 41.66% <0.00%> (-58.34%) ⬇️
docarray/array/mixins/group.py 44.73% <0.00%> (-44.74%) ⬇️
docarray/array/mixins/io/common.py 26.31% <0.00%> (-42.11%) ⬇️
docarray/array/storage/memory/find.py 54.68% <0.00%> (-40.63%) ⬇️
docarray/array/mixins/io/json.py 68.75% <0.00%> (-25.00%) ⬇️
docarray/document/mixins/sugar.py 60.00% <0.00%> (-20.00%) ⬇️
docarray/math/helper.py 67.64% <0.00%> (-17.65%) ⬇️
... and 35 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@samsja samsja closed this Dec 14, 2022
@samsja samsja reopened this Dec 14, 2022
Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr>
Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr>
Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr>
Comment thread .github/workflows/ci.yml Outdated
Comment thread .github/workflows/cd.yml
Comment thread .github/workflows/ci.yml Outdated
Comment thread .github/workflows/ci.yml Outdated
samsja and others added 2 commits December 14, 2022 09:45
Co-authored-by: AlaeddineAbdessalem <alaeddine-13@live.fr>
Signed-off-by: samsja <55492238+samsja@users.noreply.github.com>
Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr>
Comment thread .github/workflows/ci.yml Outdated
@samsja samsja requested a review from alaeddine-13 December 15, 2022 08:22
@JoanFM JoanFM merged commit ed690c8 into main Dec 16, 2022
@JoanFM JoanFM deleted the chore-updage-cicd branch December 16, 2022 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants