feat: add exclude fields metas parameter#891
Merged
Merged
Conversation
JoanFM
requested changes
Dec 5, 2022
Codecov ReportBase: 88.15% // Head: 83.74% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #891 +/- ##
==========================================
- Coverage 88.15% 83.74% -4.41%
==========================================
Files 138 138
Lines 7148 7148
==========================================
- Hits 6301 5986 -315
- Misses 847 1162 +315
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
added 3 commits
December 5, 2022 12:06
Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>
Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>
Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>
cb7003e to
8b74f55
Compare
JohannesMessner
requested changes
Dec 5, 2022
JohannesMessner
left a comment
Member
There was a problem hiding this comment.
We need to document this, otherwise it looks good to me!
Also, is there a reason the argument is called exclude_fields_metas and not just exclude_fields or something like that?
Co-authored-by: Johannes Messner <44071807+JohannesMessner@users.noreply.github.com> Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>
Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>
Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>
alexcg1
suggested changes
Dec 5, 2022
Co-authored-by: Alex Cureton-Griffiths <alexcg1@users.noreply.github.com> Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>
alexcg1
approved these changes
Dec 5, 2022
Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>
JohannesMessner
approved these changes
Dec 5, 2022
JoanFM
requested changes
Dec 5, 2022
Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>
|
📝 Docs are deployed on https://ft-fix-plot-embeddings--jina-docs.netlify.app 🎉 |
JoanFM
approved these changes
Dec 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: anna-charlotte charlotte.gerhaher@jina.ai
Add the option to exclude additional fields from csv metadata file, such as
.chunksby adding the parameterexclude_fields_metasto.plot_embedding.exclude_fields_metas