Skip to content

ci: fix the wrong error msg#882

Merged
samsja merged 11 commits into
mainfrom
ci-remove-error-return-1201
Dec 1, 2022
Merged

ci: fix the wrong error msg#882
samsja merged 11 commits into
mainfrom
ci-remove-error-return-1201

Conversation

@nan-wang

@nan-wang nan-wang commented Dec 1, 2022

Copy link
Copy Markdown
Collaborator

Signed-off-by: Nan Wang nan.wang@jina.ai

Goals:

Signed-off-by: Nan Wang <nan.wang@jina.ai>
Signed-off-by: Nan Wang <nan.wang@jina.ai>
Signed-off-by: Nan Wang <nan.wang@jina.ai>
Signed-off-by: Nan Wang <nan.wang@jina.ai>
Signed-off-by: Nan Wang <nan.wang@jina.ai>
Signed-off-by: Nan Wang <nan.wang@jina.ai>
Signed-off-by: Nan Wang <nan.wang@jina.ai>
Signed-off-by: Nan Wang <nan.wang@jina.ai>
Signed-off-by: Nan Wang <nan.wang@jina.ai>
Signed-off-by: Nan Wang <nan.wang@jina.ai>
Signed-off-by: Nan Wang <nan.wang@jina.ai>
@github-actions github-actions Bot added size/s and removed size/m labels Dec 1, 2022

@samsja samsja left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov-commenter

codecov-commenter commented Dec 1, 2022

Copy link
Copy Markdown

Codecov Report

Base: 88.13% // Head: 63.57% // Decreases project coverage by -24.56% ⚠️

Coverage data is based on head (fae6085) compared to base (59db0ff).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #882       +/-   ##
===========================================
- Coverage   88.13%   63.57%   -24.57%     
===========================================
  Files         138      138               
  Lines        7137     7137               
===========================================
- Hits         6290     4537     -1753     
- Misses        847     2600     +1753     
Flag Coverage Δ
docarray 63.57% <ø> (-24.57%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
docarray/array/mixins/dataloader/helper.py 0.00% <0.00%> (-100.00%) ⬇️
docarray/array/mixins/io/pbar.py 0.00% <0.00%> (-88.89%) ⬇️
docarray/array/mixins/embed.py 9.89% <0.00%> (-82.42%) ⬇️
docarray/array/mixins/evaluation.py 8.33% <0.00%> (-80.13%) ⬇️
docarray/array/mixins/io/binary.py 20.26% <0.00%> (-79.09%) ⬇️
docarray/array/mixins/post.py 17.07% <0.00%> (-78.05%) ⬇️
docarray/array/mixins/delitem.py 11.11% <0.00%> (-77.78%) ⬇️
docarray/array/mixins/reduce.py 26.92% <0.00%> (-73.08%) ⬇️
docarray/array/mixins/io/pushpull.py 23.07% <0.00%> (-70.09%) ⬇️
docarray/array/mixins/io/csv.py 23.68% <0.00%> (-65.79%) ⬇️
... and 65 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@samsja samsja enabled auto-merge (squash) December 1, 2022 16:19
@samsja samsja merged commit ae49969 into main Dec 1, 2022
@samsja samsja deleted the ci-remove-error-return-1201 branch December 1, 2022 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants