fix: rebuild index when clear storage#837
Merged
Merged
Conversation
Signed-off-by: AnneY <evangeline-lun@foxmail.com>
Signed-off-by: AnneY <evangeline-lun@foxmail.com>
Signed-off-by: AnneY <evangeline-lun@foxmail.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #837 +/- ##
===========================================
+ Coverage 59.97% 83.40% +23.43%
===========================================
Files 138 138
Lines 7040 7046 +6
===========================================
+ Hits 4222 5877 +1655
+ Misses 2818 1169 -1649
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: AnneY <evangeline-lun@foxmail.com>
ad22dfe to
708e918
Compare
Signed-off-by: AnneY <evangeline-lun@foxmail.com>
Signed-off-by: AnneY <evangeline-lun@foxmail.com>
JohannesMessner
approved these changes
Nov 25, 2022
JoanFM
approved these changes
Nov 25, 2022
guenthermi
pushed a commit
to guenthermi/docarray
that referenced
this pull request
Nov 28, 2022
* fix: rebuild index of redis when clear storage Signed-off-by: AnneY <evangeline-lun@foxmail.com> * refactor: change build index funtion name Signed-off-by: AnneY <evangeline-lun@foxmail.com> * fix: rebuild index of elastic when clear storage Signed-off-by: AnneY <evangeline-lun@foxmail.com> * test: add tests for getset subindex in store Signed-off-by: AnneY <evangeline-lun@foxmail.com> * fix: fix elastic __setstate__ client Signed-off-by: AnneY <evangeline-lun@foxmail.com> * refactor: keep _build_client Signed-off-by: AnneY <evangeline-lun@foxmail.com> Signed-off-by: AnneY <evangeline-lun@foxmail.com>
guenthermi
pushed a commit
to guenthermi/docarray
that referenced
this pull request
Nov 28, 2022
* fix: rebuild index of redis when clear storage Signed-off-by: AnneY <evangeline-lun@foxmail.com> * refactor: change build index funtion name Signed-off-by: AnneY <evangeline-lun@foxmail.com> * fix: rebuild index of elastic when clear storage Signed-off-by: AnneY <evangeline-lun@foxmail.com> * test: add tests for getset subindex in store Signed-off-by: AnneY <evangeline-lun@foxmail.com> * fix: fix elastic __setstate__ client Signed-off-by: AnneY <evangeline-lun@foxmail.com> * refactor: keep _build_client Signed-off-by: AnneY <evangeline-lun@foxmail.com> Signed-off-by: AnneY <evangeline-lun@foxmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: AnneY evangeline-lun@foxmail.com
Goals:
This PR is related to issue #829 and will rebuild index for Redis and ElasticSearch when
_clear_storageis called.