Skip to content

fix: change annlite extend to private function#828

Merged
JohannesMessner merged 2 commits into
mainfrom
fix-annlite-extend
Nov 23, 2022
Merged

fix: change annlite extend to private function#828
JohannesMessner merged 2 commits into
mainfrom
fix-annlite-extend

Conversation

@AnneYang720

Copy link
Copy Markdown
Contributor

Signed-off-by: AnneY evangeline-lun@foxmail.com

Goals:

Change extend of annlite storage backend to private function _extend.

Signed-off-by: AnneY <evangeline-lun@foxmail.com>
@codecov-commenter

codecov-commenter commented Nov 22, 2022

Copy link
Copy Markdown

Codecov Report

Base: 65.13% // Head: 65.12% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (ee29da7) compared to base (61fb708).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #828      +/-   ##
==========================================
- Coverage   65.13%   65.12%   -0.01%     
==========================================
  Files         138      138              
  Lines        7041     7040       -1     
==========================================
- Hits         4586     4585       -1     
  Misses       2455     2455              
Flag Coverage Δ
docarray 65.12% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
docarray/array/storage/annlite/seqlike.py 64.00% <100.00%> (-1.39%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@AnneYang720 AnneYang720 marked this pull request as ready for review November 23, 2022 08:27
@JohannesMessner JohannesMessner merged commit 81e0500 into main Nov 23, 2022
@JohannesMessner JohannesMessner deleted the fix-annlite-extend branch November 23, 2022 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants