refactor: add typing abstract class#824
Merged
Merged
Conversation
1aeab2a to
c9116e0
Compare
c9116e0 to
a8bf6a1
Compare
samsja
reviewed
Nov 22, 2022
287da65 to
dc3b924
Compare
samsja
reviewed
Nov 23, 2022
3915872 to
3261f09
Compare
87c8d11 to
7146beb
Compare
samsja
reviewed
Nov 23, 2022
6ac29f7 to
2f43b48
Compare
samsja
reviewed
Nov 23, 2022
0cdc036 to
3244546
Compare
JohannesMessner
previously requested changes
Nov 23, 2022
samsja
reviewed
Nov 23, 2022
samsja
reviewed
Nov 23, 2022
samsja
reviewed
Nov 23, 2022
samsja
reviewed
Nov 23, 2022
samsja
reviewed
Nov 23, 2022
1123c74 to
a7e6263
Compare
samsja
reviewed
Nov 24, 2022
715c1c1 to
0c80e6b
Compare
008f3e4 to
c66890f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: dong xiang iamxiangdong@gmail.com
Goals:
We need to create an common interface via an abstract class for our docarray.typing obj
The abstract class should contain the following methods, 1. _to_node_protobuf (Convert Document into a NodeProto protobuf message). 2. from_protobuf (read value from a proto msg) 3. validate (inherited from pydantic about validating data.)