feat: image url#811
Merged
Merged
Conversation
…tte-v2 # Conflicts: # docarray/document/mixins/proto.py # docarray/typing/ndarray.py # docarray/typing/tensor/__init__.py # docarray/typing/tensor/tensor.py # docarray/typing/url/image_url.py # tests/integrations/typing/tensor.py # tests/units/document/proto/test_proto_based_object.py # tests/units/typing/test_image_url.py
Signed-off-by: Johannes Messner <messnerjo@gmail.com>
Signed-off-by: Johannes Messner <messnerjo@gmail.com>
Signed-off-by: Johannes Messner <messnerjo@gmail.com>
Co-authored-by: samsja <55492238+samsja@users.noreply.github.com> Signed-off-by: Johannes Messner <44071807+JohannesMessner@users.noreply.github.com>
Signed-off-by: Johannes Messner <messnerjo@gmail.com>
Signed-off-by: Johannes Messner <messnerjo@gmail.com>
Signed-off-by: Johannes Messner <messnerjo@gmail.com>
Signed-off-by: Johannes Messner <messnerjo@gmail.com>
Signed-off-by: Johannes Messner <messnerjo@gmail.com>
Signed-off-by: Johannes Messner <messnerjo@gmail.com>
Signed-off-by: Johannes Messner <messnerjo@gmail.com>
Signed-off-by: Johannes Messner <messnerjo@gmail.com>
Signed-off-by: Johannes Messner <messnerjo@gmail.com>
Signed-off-by: Johannes Messner <messnerjo@gmail.com>
Signed-off-by: Johannes Messner <messnerjo@gmail.com>
Signed-off-by: Johannes Messner <messnerjo@gmail.com>
Signed-off-by: Johannes Messner <44071807+JohannesMessner@users.noreply.github.com>
Signed-off-by: Johannes Messner <messnerjo@gmail.com>
samsja
reviewed
Nov 21, 2022
Signed-off-by: Johannes Messner <messnerjo@gmail.com>
samsja
reviewed
Nov 21, 2022
Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr>
dongxiang123
approved these changes
Nov 21, 2022
samsja
approved these changes
Nov 21, 2022
dongxiang123
pushed a commit
that referenced
this pull request
Nov 21, 2022
* feat: add tensor type for ndarray * fix: fix mypy typing * feat: torch tensor type Signed-off-by: Johannes Messner <messnerjo@gmail.com> * fix: protobuf for pytorch type Signed-off-by: Johannes Messner <messnerjo@gmail.com> * ci: install all extras in the ci Signed-off-by: Johannes Messner <messnerjo@gmail.com> * refactor: make nice looking * docs: update docarray/typing/tensor/torch_tensor.py Co-authored-by: samsja <55492238+samsja@users.noreply.github.com> Signed-off-by: Johannes Messner <44071807+JohannesMessner@users.noreply.github.com> * refactor: code style Signed-off-by: Johannes Messner <messnerjo@gmail.com> * fix: black and mypy Signed-off-by: Johannes Messner <messnerjo@gmail.com> * fix: suppress mypy import error * ci: fix ci install Signed-off-by: Johannes Messner <messnerjo@gmail.com> * feat: add new type for image urls Signed-off-by: Johannes Messner <messnerjo@gmail.com> * feat: add new type for image urls Signed-off-by: Johannes Messner <messnerjo@gmail.com> * test: add real existing url to test Signed-off-by: Johannes Messner <messnerjo@gmail.com> * test: test output of image buffer loading Signed-off-by: Johannes Messner <messnerjo@gmail.com> * feat: add validation for image url Signed-off-by: Johannes Messner <messnerjo@gmail.com> * feat: specify image axis permutation Signed-off-by: Johannes Messner <messnerjo@gmail.com> * docs: add docstrings Signed-off-by: Johannes Messner <messnerjo@gmail.com> * docs: make strings uniform Signed-off-by: Johannes Messner <messnerjo@gmail.com> * test: pass valid url as imageurl Signed-off-by: Johannes Messner <messnerjo@gmail.com> * chore: fix dependencies Signed-off-by: Johannes Messner <messnerjo@gmail.com> * chore(ci): add extras to mypy ci Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr> Signed-off-by: Johannes Messner <messnerjo@gmail.com> Signed-off-by: Johannes Messner <44071807+JohannesMessner@users.noreply.github.com> Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr> Co-authored-by: samsja <55492238+samsja@users.noreply.github.com> Co-authored-by: Sami Jaghouar <sami.jaghouar@hotmail.fr>
dongxiang123
pushed a commit
that referenced
this pull request
Nov 21, 2022
* feat: add tensor type for ndarray * fix: fix mypy typing * feat: torch tensor type Signed-off-by: Johannes Messner <messnerjo@gmail.com> * fix: protobuf for pytorch type Signed-off-by: Johannes Messner <messnerjo@gmail.com> * ci: install all extras in the ci Signed-off-by: Johannes Messner <messnerjo@gmail.com> * refactor: make nice looking * docs: update docarray/typing/tensor/torch_tensor.py Co-authored-by: samsja <55492238+samsja@users.noreply.github.com> Signed-off-by: Johannes Messner <44071807+JohannesMessner@users.noreply.github.com> * refactor: code style Signed-off-by: Johannes Messner <messnerjo@gmail.com> * fix: black and mypy Signed-off-by: Johannes Messner <messnerjo@gmail.com> * fix: suppress mypy import error * ci: fix ci install Signed-off-by: Johannes Messner <messnerjo@gmail.com> * feat: add new type for image urls Signed-off-by: Johannes Messner <messnerjo@gmail.com> * feat: add new type for image urls Signed-off-by: Johannes Messner <messnerjo@gmail.com> * test: add real existing url to test Signed-off-by: Johannes Messner <messnerjo@gmail.com> * test: test output of image buffer loading Signed-off-by: Johannes Messner <messnerjo@gmail.com> * feat: add validation for image url Signed-off-by: Johannes Messner <messnerjo@gmail.com> * feat: specify image axis permutation Signed-off-by: Johannes Messner <messnerjo@gmail.com> * docs: add docstrings Signed-off-by: Johannes Messner <messnerjo@gmail.com> * docs: make strings uniform Signed-off-by: Johannes Messner <messnerjo@gmail.com> * test: pass valid url as imageurl Signed-off-by: Johannes Messner <messnerjo@gmail.com> * chore: fix dependencies Signed-off-by: Johannes Messner <messnerjo@gmail.com> * chore(ci): add extras to mypy ci Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr> Signed-off-by: Johannes Messner <messnerjo@gmail.com> Signed-off-by: Johannes Messner <44071807+JohannesMessner@users.noreply.github.com> Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr> Co-authored-by: samsja <55492238+samsja@users.noreply.github.com> Co-authored-by: Sami Jaghouar <sami.jaghouar@hotmail.fr>
dongxiang123
pushed a commit
that referenced
this pull request
Nov 21, 2022
* feat: add tensor type for ndarray * fix: fix mypy typing * feat: torch tensor type Signed-off-by: Johannes Messner <messnerjo@gmail.com> * fix: protobuf for pytorch type Signed-off-by: Johannes Messner <messnerjo@gmail.com> * ci: install all extras in the ci Signed-off-by: Johannes Messner <messnerjo@gmail.com> * refactor: make nice looking * docs: update docarray/typing/tensor/torch_tensor.py Co-authored-by: samsja <55492238+samsja@users.noreply.github.com> Signed-off-by: Johannes Messner <44071807+JohannesMessner@users.noreply.github.com> * refactor: code style Signed-off-by: Johannes Messner <messnerjo@gmail.com> * fix: black and mypy Signed-off-by: Johannes Messner <messnerjo@gmail.com> * fix: suppress mypy import error * ci: fix ci install Signed-off-by: Johannes Messner <messnerjo@gmail.com> * feat: add new type for image urls Signed-off-by: Johannes Messner <messnerjo@gmail.com> * feat: add new type for image urls Signed-off-by: Johannes Messner <messnerjo@gmail.com> * test: add real existing url to test Signed-off-by: Johannes Messner <messnerjo@gmail.com> * test: test output of image buffer loading Signed-off-by: Johannes Messner <messnerjo@gmail.com> * feat: add validation for image url Signed-off-by: Johannes Messner <messnerjo@gmail.com> * feat: specify image axis permutation Signed-off-by: Johannes Messner <messnerjo@gmail.com> * docs: add docstrings Signed-off-by: Johannes Messner <messnerjo@gmail.com> * docs: make strings uniform Signed-off-by: Johannes Messner <messnerjo@gmail.com> * test: pass valid url as imageurl Signed-off-by: Johannes Messner <messnerjo@gmail.com> * chore: fix dependencies Signed-off-by: Johannes Messner <messnerjo@gmail.com> * chore(ci): add extras to mypy ci Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr> Signed-off-by: Johannes Messner <messnerjo@gmail.com> Signed-off-by: Johannes Messner <44071807+JohannesMessner@users.noreply.github.com> Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr> Co-authored-by: samsja <55492238+samsja@users.noreply.github.com> Co-authored-by: Sami Jaghouar <sami.jaghouar@hotmail.fr>
dongxiang123
pushed a commit
that referenced
this pull request
Nov 21, 2022
* feat: add tensor type for ndarray * fix: fix mypy typing * feat: torch tensor type Signed-off-by: Johannes Messner <messnerjo@gmail.com> * fix: protobuf for pytorch type Signed-off-by: Johannes Messner <messnerjo@gmail.com> * ci: install all extras in the ci Signed-off-by: Johannes Messner <messnerjo@gmail.com> * refactor: make nice looking * docs: update docarray/typing/tensor/torch_tensor.py Co-authored-by: samsja <55492238+samsja@users.noreply.github.com> Signed-off-by: Johannes Messner <44071807+JohannesMessner@users.noreply.github.com> * refactor: code style Signed-off-by: Johannes Messner <messnerjo@gmail.com> * fix: black and mypy Signed-off-by: Johannes Messner <messnerjo@gmail.com> * fix: suppress mypy import error * ci: fix ci install Signed-off-by: Johannes Messner <messnerjo@gmail.com> * feat: add new type for image urls Signed-off-by: Johannes Messner <messnerjo@gmail.com> * feat: add new type for image urls Signed-off-by: Johannes Messner <messnerjo@gmail.com> * test: add real existing url to test Signed-off-by: Johannes Messner <messnerjo@gmail.com> * test: test output of image buffer loading Signed-off-by: Johannes Messner <messnerjo@gmail.com> * feat: add validation for image url Signed-off-by: Johannes Messner <messnerjo@gmail.com> * feat: specify image axis permutation Signed-off-by: Johannes Messner <messnerjo@gmail.com> * docs: add docstrings Signed-off-by: Johannes Messner <messnerjo@gmail.com> * docs: make strings uniform Signed-off-by: Johannes Messner <messnerjo@gmail.com> * test: pass valid url as imageurl Signed-off-by: Johannes Messner <messnerjo@gmail.com> * chore: fix dependencies Signed-off-by: Johannes Messner <messnerjo@gmail.com> * chore(ci): add extras to mypy ci Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr> Signed-off-by: Johannes Messner <messnerjo@gmail.com> Signed-off-by: Johannes Messner <44071807+JohannesMessner@users.noreply.github.com> Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr> Co-authored-by: samsja <55492238+samsja@users.noreply.github.com> Co-authored-by: Sami Jaghouar <sami.jaghouar@hotmail.fr>
dongxiang123
pushed a commit
that referenced
this pull request
Nov 21, 2022
* feat: add tensor type for ndarray * fix: fix mypy typing * feat: torch tensor type Signed-off-by: Johannes Messner <messnerjo@gmail.com> * fix: protobuf for pytorch type Signed-off-by: Johannes Messner <messnerjo@gmail.com> * ci: install all extras in the ci Signed-off-by: Johannes Messner <messnerjo@gmail.com> * refactor: make nice looking * docs: update docarray/typing/tensor/torch_tensor.py Co-authored-by: samsja <55492238+samsja@users.noreply.github.com> Signed-off-by: Johannes Messner <44071807+JohannesMessner@users.noreply.github.com> * refactor: code style Signed-off-by: Johannes Messner <messnerjo@gmail.com> * fix: black and mypy Signed-off-by: Johannes Messner <messnerjo@gmail.com> * fix: suppress mypy import error * ci: fix ci install Signed-off-by: Johannes Messner <messnerjo@gmail.com> * feat: add new type for image urls Signed-off-by: Johannes Messner <messnerjo@gmail.com> * feat: add new type for image urls Signed-off-by: Johannes Messner <messnerjo@gmail.com> * test: add real existing url to test Signed-off-by: Johannes Messner <messnerjo@gmail.com> * test: test output of image buffer loading Signed-off-by: Johannes Messner <messnerjo@gmail.com> * feat: add validation for image url Signed-off-by: Johannes Messner <messnerjo@gmail.com> * feat: specify image axis permutation Signed-off-by: Johannes Messner <messnerjo@gmail.com> * docs: add docstrings Signed-off-by: Johannes Messner <messnerjo@gmail.com> * docs: make strings uniform Signed-off-by: Johannes Messner <messnerjo@gmail.com> * test: pass valid url as imageurl Signed-off-by: Johannes Messner <messnerjo@gmail.com> * chore: fix dependencies Signed-off-by: Johannes Messner <messnerjo@gmail.com> * chore(ci): add extras to mypy ci Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr> Signed-off-by: Johannes Messner <messnerjo@gmail.com> Signed-off-by: Johannes Messner <44071807+JohannesMessner@users.noreply.github.com> Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr> Co-authored-by: samsja <55492238+samsja@users.noreply.github.com> Co-authored-by: Sami Jaghouar <sami.jaghouar@hotmail.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goals:
This adds the type
ImageUrl.For now it can:
TODO: