feat: encode primitive type in the proto#772
Merged
Merged
Conversation
Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr>
Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr>
Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr>
Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr>
Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr>
Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr>
b7ba688 to
5c87798
Compare
JoanFM
requested changes
Nov 14, 2022
JoanFM
requested changes
Nov 14, 2022
Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr>
Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr>
Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr>
JoanFM
previously requested changes
Nov 14, 2022
JohannesMessner
approved these changes
Nov 15, 2022
Member
|
Let's keep in mind that we might have to move the |
JohannesMessner
pushed a commit
that referenced
this pull request
Nov 16, 2022
* refactor: change embedding and base node Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr> * fix: expose any url to user Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr> * refactor: docarray type are relfected at the proto level Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr> * fix: add test and fix dump to proto Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr> * refactor: move get nested class to document Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr> * fix: fix mypy return type hint Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr> * feat: add id as a type Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr> * feat: adapt proto to the new id type Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr> * fix(proto): does not return mixin anymore type Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr> Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr> Signed-off-by: Johannes Messner <messnerjo@gmail.com>
samsja
added a commit
that referenced
this pull request
Nov 17, 2022
* refactor: change embedding and base node Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr> * fix: expose any url to user Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr> * refactor: docarray type are relfected at the proto level Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr> * fix: add test and fix dump to proto Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr> * refactor: move get nested class to document Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr> * fix: fix mypy return type hint Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr> * feat: add id as a type Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr> * feat: adapt proto to the new id type Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr> * fix(proto): does not return mixin anymore type Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr> Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
context
We want to re transcript the primitive type into the document proto. This pr do this with the current type
FYI : #760