chore(ci): readd commint lint#769
Merged
Merged
Conversation
Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr>
Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr>
8a0831b to
013d0cd
Compare
Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr>
Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr>
Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr>
Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr>
Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr>
Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr>
Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr>
Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr>
JohannesMessner
left a comment
Member
There was a problem hiding this comment.
Should we start to not care about bad commit messages anymore as long as the final one that we merge is ok?
Member
Author
lets take this decision after we merge this branch in master, my fear is that we will not be able to merge otherwise |
JohannesMessner
approved these changes
Nov 14, 2022
JohannesMessner
pushed a commit
that referenced
this pull request
Nov 16, 2022
* chore(ci): readd commint lint Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr> * chore(ci): add commit link to sucessful Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr> * chore(ci): fix ci Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr> * chore(ci): test disable commit lint comment Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr> * chore(ci): fix do ci only once Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr> * chore(ci): fix blsck Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr> * chore(ci): update on what trigger pr Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr> * chore(ci): apply black Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr> * chore(ci): add check mypy to success all Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr> * chore(ci): re add commit link comment Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr> Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr> Signed-off-by: Johannes Messner <messnerjo@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sami Jaghouar sami.jaghouar@hotmail.fr
What this PR do