Skip to content

fix: customize metric fn expect no metric_name#405

Merged
hanxiao merged 1 commit into
mainfrom
fix-customize-metric-fn
Jun 20, 2022
Merged

fix: customize metric fn expect no metric_name#405
hanxiao merged 1 commit into
mainfrom
fix-customize-metric-fn

Conversation

@hanxiao

@hanxiao hanxiao commented Jun 20, 2022

Copy link
Copy Markdown
Member

Goals:

  • ...
  • ...
  • check and update documentation, if required. See guide

@codecov

codecov Bot commented Jun 20, 2022

Copy link
Copy Markdown

Codecov Report

Merging #405 (e4aa4a8) into main (64f8ff5) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #405   +/-   ##
=======================================
  Coverage   86.53%   86.53%           
=======================================
  Files         134      134           
  Lines        6388     6388           
=======================================
  Hits         5528     5528           
  Misses        860      860           
Flag Coverage Δ
docarray 86.53% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
docarray/__init__.py 75.00% <100.00%> (ø)
docarray/array/storage/memory/find.py 91.22% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a3ba78...e4aa4a8. Read the comment docs.

@hanxiao hanxiao merged commit 18a1c46 into main Jun 20, 2022
@hanxiao hanxiao deleted the fix-customize-metric-fn branch June 20, 2022 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant