Skip to content

fix: convert mesh tensor to nparray #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hanxiao merged 1 commit into from
Jun 20, 2022
Merged

fix: convert mesh tensor to nparray #404

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions docarray/document/mixins/mesh.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
from typing import TYPE_CHECKING

import numpy as np

if TYPE_CHECKING:
from ...typing import T

Expand Down Expand Up @@ -31,10 +33,10 @@ def load_uri_to_point_cloud_tensor(
scene = loader(self.uri, force='scene')
for geo in scene.geometry.values():
geo: trimesh.Trimesh
self.chunks.append(Document(tensor=geo.sample(samples)))
self.chunks.append(Document(tensor=np.array(geo.sample(samples))))
else:
# combine a scene into a single mesh
mesh = loader(self.uri, force='mesh')
self.tensor = mesh.sample(samples)
self.tensor = np.array(mesh.sample(samples))

return self
1 change: 1 addition & 0 deletions tests/unit/document/test_converters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,7 @@ def test_glb_converters(uri, chunk_num):
doc = Document(uri=uri)
doc.load_uri_to_point_cloud_tensor(2000)
assert doc.tensor.shape == (2000, 3)
assert isinstance(doc.tensor, np.ndarray)

doc.load_uri_to_point_cloud_tensor(2000, as_chunks=True)
assert len(doc.chunks) == chunk_num
Expand Down