Skip to content

feat: annlite find with filter and no query vector#401

Merged
alaeddine-13 merged 3 commits into
mainfrom
feat-annlite-filter
Jun 13, 2022
Merged

feat: annlite find with filter and no query vector#401
alaeddine-13 merged 3 commits into
mainfrom
feat-annlite-filter

Conversation

@davidbp

@davidbp davidbp commented Jun 13, 2022

Copy link
Copy Markdown
Contributor

closes: #395

@codecov

codecov Bot commented Jun 13, 2022

Copy link
Copy Markdown

Codecov Report

Merging #401 (b30690c) into main (1482421) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #401      +/-   ##
==========================================
+ Coverage   86.51%   86.53%   +0.02%     
==========================================
  Files         134      134              
  Lines        6385     6388       +3     
==========================================
+ Hits         5524     5528       +4     
+ Misses        861      860       -1     
Flag Coverage Δ
docarray 86.53% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
docarray/__init__.py 75.00% <100.00%> (ø)
docarray/array/storage/annlite/find.py 93.33% <100.00%> (+10.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aad1e1f...b30690c. Read the comment docs.

@davidbp davidbp marked this pull request as ready for review June 13, 2022 10:43

@alaeddine-13 alaeddine-13 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since there's a new feature in annlite, I guess annlite version should be more than 0.3.2 or more

Comment thread docs/advanced/document-store/annlite.md Outdated
@github-actions

Copy link
Copy Markdown

📝 Docs are deployed on https://ft-feat-annlite-filter--jina-docs.netlify.app 🎉

@alaeddine-13 alaeddine-13 merged commit 52fde78 into main Jun 13, 2022
@alaeddine-13 alaeddine-13 deleted the feat-annlite-filter branch June 13, 2022 12:42
@JoanFM JoanFM linked an issue Jun 21, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support filtering in AnnLite Backend (docarray repo) Support filtering for annlite

2 participants