fix: cast column to its correct type before insertion in database#392
Merged
Conversation
JoanFM
requested changes
Jun 7, 2022
JoanFM
left a comment
Member
There was a problem hiding this comment.
some test should be added/modified
Codecov Report
@@ Coverage Diff @@
## main #392 +/- ##
==========================================
+ Coverage 84.77% 86.47% +1.70%
==========================================
Files 134 134
Lines 6358 6367 +9
==========================================
+ Hits 5390 5506 +116
+ Misses 968 861 -107
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
samsja
reviewed
Jun 7, 2022
added 2 commits
June 9, 2022 11:24
6d08623 to
c1ece84
Compare
alaeddine-13
commented
Jun 9, 2022
Co-authored-by: AlaeddineAbdessalem <alaeddine-13@live.fr>
JoanFM
approved these changes
Jun 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #391