Skip to content

refactor: remove redundant code#390

Merged
hanxiao merged 1 commit into
mainfrom
refactor-code-review
Jun 6, 2022
Merged

refactor: remove redundant code#390
hanxiao merged 1 commit into
mainfrom
refactor-code-review

Conversation

@hanxiao

@hanxiao hanxiao commented Jun 6, 2022

Copy link
Copy Markdown
Member

Goals:

  • ...
  • ...
  • check and update documentation, if required. See guide

@codecov

codecov Bot commented Jun 6, 2022

Copy link
Copy Markdown

Codecov Report

Merging #390 (5086f9a) into main (2098aa7) will increase coverage by 1.57%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #390      +/-   ##
==========================================
+ Coverage   84.87%   86.45%   +1.57%     
==========================================
  Files         134      134              
  Lines        6382     6358      -24     
==========================================
+ Hits         5417     5497      +80     
+ Misses        965      861     -104     
Flag Coverage Δ
docarray 86.45% <100.00%> (+1.57%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
docarray/__init__.py 75.00% <100.00%> (-25.00%) ⬇️
docarray/helper.py 81.39% <100.00%> (+4.82%) ⬆️
docarray/array/mixins/find.py 87.35% <0.00%> (+1.14%) ⬆️
docarray/array/storage/sqlite/seqlike.py 85.18% <0.00%> (+1.85%) ⬆️
docarray/array/mixins/io/binary.py 97.45% <0.00%> (+2.54%) ⬆️
docarray/math/ndarray.py 90.00% <0.00%> (+2.66%) ⬆️
docarray/array/storage/weaviate/seqlike.py 77.41% <0.00%> (+3.22%) ⬆️
docarray/array/mixins/io/from_gen.py 83.63% <0.00%> (+3.63%) ⬆️
docarray/array/storage/weaviate/backend.py 87.50% <0.00%> (+3.67%) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2098aa7...5086f9a. Read the comment docs.

@hanxiao hanxiao merged commit d559752 into main Jun 6, 2022
@hanxiao hanxiao deleted the refactor-code-review branch June 6, 2022 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant