fix(tests): eq and neq operator for qdrant filtering #388
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #388 +/- ##
==========================================
+ Coverage 84.57% 86.29% +1.71%
==========================================
Files 134 134
Lines 6368 6368
==========================================
+ Hits 5386 5495 +109
+ Misses 982 873 -109
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Pre-filtering with the operator equal is not working with qdrant backend. See full issue for details #387
Solution
To do filtering with with
eqandneqone should use thematchkeyword.for
eq:filter = {'must': [{'key': 'price', 'match': {'value': 7}}]}for
neq:filter = {'must_not': [{'key': 'price', 'match': {'value': 7}}]}
What this pr do
This pr fix the test to use this notation for the filter